Change in coreboot[master]: drivers/wifi: Adapt generic wifi driver into a chip driver - coreboot-gerrit

25 Jul 2020


      Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43768 )
Change subject: drivers/wifi: Adapt generic wifi driver into a chip driver
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/43768/4/src/drivers/wifi/generic/ge... 
File src/drivers/wifi/generic/generic.c:
https://review.coreboot.org/c/coreboot/+/43768/4/src/drivers/wifi/generic/ge... 
PS4, Line 243: #if CONFIG(HAVE_ACPI_TABLES)
nit: Not required. This file is added only when HAVE_ACPI_TABLES is selected.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/43768
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63f957a008ecf4a6a810c2a135ed62ea81a79fe0
Gerrit-Change-Number: 43768
Gerrit-PatchSet: 4
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Justin TerAvest teravest@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 25 Jul 2020 00:14:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment