Change in coreboot[master]: src/superio: Add missing '#include <stddef.h>'

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

27 Jul 2020 27 Jul '20

8:05 a.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43942 )

Change subject: src/superio: Add missing '#include <stddef.h>' ......................................................................

src/superio: Add missing '#include <stddef.h>'

size_t needs <stddef.h>.

Change-Id: Ic6ffeb3881ee581c5e5b5d614dfd6efda2e5b2c2 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/aspeed/ast2400/superio.c M src/superio/smsc/sch5545/sch5545_emi.c M src/superio/smsc/sch5545/sch5545_emi.h 3 files changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/43942/1

diff --git a/src/superio/aspeed/ast2400/superio.c b/src/superio/aspeed/ast2400/superio.c index 4510c21..1c6e436 100644 --- a/src/superio/aspeed/ast2400/superio.c +++ b/src/superio/aspeed/ast2400/superio.c @@ -6,6 +6,8 @@ #include <pc80/keyboard.h> #include <superio/common/ssdt.h> #include <acpi/acpi.h> +#include <stddef.h> + #include "ast2400.h" #include "chip.h"

diff --git a/src/superio/smsc/sch5545/sch5545_emi.c b/src/superio/smsc/sch5545/sch5545_emi.c index 2bb150c..8031129 100644 --- a/src/superio/smsc/sch5545/sch5545_emi.c +++ b/src/superio/smsc/sch5545/sch5545_emi.c @@ -5,6 +5,7 @@ #include <device/pnp.h> #include <device/pnp_def.h> #include <device/pnp_ops.h> +#include <stddef.h> #include <superio/conf_mode.h>

#include "sch5545.h" diff --git a/src/superio/smsc/sch5545/sch5545_emi.h b/src/superio/smsc/sch5545/sch5545_emi.h index 2bf3a76..5b622de 100644 --- a/src/superio/smsc/sch5545/sch5545_emi.h +++ b/src/superio/smsc/sch5545/sch5545_emi.h @@ -3,6 +3,7 @@ #ifndef SUPERIO_SCH_5545_EMI_H #define SUPERIO_SCH_5545_EMI_H

+#include <stddef.h> #include <stdlib.h> #include <stdint.h>

Attachments:

attachment.htm (text/html — 3.7 KB)

Show replies by date

HAOUAS Elyes (Code Review)

27 Jul 27 Jul

11:29 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43942 )

Change subject: src/superio: Add missing '#include <stddef.h>' ......................................................................

Patch Set 1:

(3 comments)

I've added comments to make the review easy

https://review.coreboot.org/c/coreboot/+/43942/1/src/superio/aspeed/ast2400/... File src/superio/aspeed/ast2400/superio.c:

https://review.coreboot.org/c/coreboot/+/43942/1/src/superio/aspeed/ast2400/... PS1, Line 96: size_t stddef

https://review.coreboot.org/c/coreboot/+/43942/1/src/superio/smsc/sch5545/sc... File src/superio/smsc/sch5545/sch5545_emi.h:

https://review.coreboot.org/c/coreboot/+/43942/1/src/superio/smsc/sch5545/sc... PS1, Line 141: size_t stddef

https://review.coreboot.org/c/coreboot/+/43942/1/src/superio/smsc/sch5545/sc... File src/superio/smsc/sch5545/sch5545_emi.c:

https://review.coreboot.org/c/coreboot/+/43942/1/src/superio/smsc/sch5545/sc... PS1, Line 179: size_t stddef

Felix Held (Code Review)

4 Aug 4 Aug

11:09 p.m.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43942 )

Change subject: src/superio: Add missing '#include <stddef.h>' ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/43942/1/src/superio/smsc/sch5545/sc... File src/superio/smsc/sch5545/sch5545_emi.h:

https://review.coreboot.org/c/coreboot/+/43942/1/src/superio/smsc/sch5545/sc... PS1, Line 6: #include <stddef.h> add types.h?

-- To view, visit https://review.coreboot.org/c/coreboot/+/43942 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic6ffeb3881ee581c5e5b5d614dfd6efda2e5b2c2 Gerrit-Change-Number: 43942 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 04 Aug 2020 21:09:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

11:48 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43942 )

Change subject: src/superio: Add missing '#include <stddef.h>' ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43942/1/src/superio/smsc/sch5545/sc... File src/superio/smsc/sch5545/sch5545_emi.c:

https://review.coreboot.org/c/coreboot/+/43942/1/src/superio/smsc/sch5545/sc... PS1, Line 30: uint8_t stdint

-- To view, visit https://review.coreboot.org/c/coreboot/+/43942 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic6ffeb3881ee581c5e5b5d614dfd6efda2e5b2c2 Gerrit-Change-Number: 43942 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 04 Aug 2020 21:48:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

10 Aug 10 Aug

1:25 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43942 )

Change subject: src/superio: Add missing '#include <stddef.h>' ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43942/1/src/superio/smsc/sch5545/sc... File src/superio/smsc/sch5545/sch5545_emi.c:

https://review.coreboot.org/c/coreboot/+/43942/1/src/superio/smsc/sch5545/sc... PS1, Line 30: uint8_t

...

stdint

not related

-- To view, visit https://review.coreboot.org/c/coreboot/+/43942 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic6ffeb3881ee581c5e5b5d614dfd6efda2e5b2c2 Gerrit-Change-Number: 43942 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 10 Aug 2020 11:25:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

1:29 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43942 )

Change subject: src/superio: Add missing '#include <stddef.h>' ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43942/1/src/superio/smsc/sch5545/sc... File src/superio/smsc/sch5545/sch5545_emi.h:

https://review.coreboot.org/c/coreboot/+/43942/1/src/superio/smsc/sch5545/sc... PS1, Line 6: #include <stddef.h>

...

add types. […]

types will include more than 6 headers. maybe we don't need them all here.

please see https://review.coreboot.org/c/coreboot/+/43952 Thx

-- To view, visit https://review.coreboot.org/c/coreboot/+/43942 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic6ffeb3881ee581c5e5b5d614dfd6efda2e5b2c2 Gerrit-Change-Number: 43942 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 10 Aug 2020 11:29:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de Gerrit-MessageType: comment

Angel Pons (Code Review)

2:13 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43942 )

Change subject: src/superio: Add missing '#include <stddef.h>' ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43942/1/src/superio/smsc/sch5545/sc... File src/superio/smsc/sch5545/sch5545_emi.h:

https://review.coreboot.org/c/coreboot/+/43942/1/src/superio/smsc/sch5545/sc... PS1, Line 6: #include <stddef.h>

...

types will include more than 6 headers. […]

I'd rather use a single #include <types.h> than have multiple included headers and the risk of inadvertently relying on indirect inclusion from other files.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43942 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic6ffeb3881ee581c5e5b5d614dfd6efda2e5b2c2 Gerrit-Change-Number: 43942 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 10 Aug 2020 12:13:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

4:38 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43942 )

Change subject: src/superio: Add missing '#include <stddef.h>' ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43942/1/src/superio/smsc/sch5545/sc... File src/superio/smsc/sch5545/sch5545_emi.h:

https://review.coreboot.org/c/coreboot/+/43942/1/src/superio/smsc/sch5545/sc... PS1, Line 6: #include <stddef.h>

...

I'd rather use a single #include <types. […]

sorry I will not in current patch.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43942 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic6ffeb3881ee581c5e5b5d614dfd6efda2e5b2c2 Gerrit-Change-Number: 43942 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 10 Aug 2020 14:38:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

19 Aug 19 Aug

9:37 a.m.

Hello build bot (Jenkins), Felix Held,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43942

to look at the new patch set (#2).

Change subject: src/superio: Add missing '#include <stddef.h>' ......................................................................

src/superio: Add missing '#include <stddef.h>'

size_t needs <stddef.h>.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/43942/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43942 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic6ffeb3881ee581c5e5b5d614dfd6efda2e5b2c2 Gerrit-Change-Number: 43942 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

20 Aug 20 Aug

8:35 a.m.

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43942 )

Change subject: src/superio: Add missing '#include <stddef.h>' ......................................................................

Abandoned

1721

days inactive

1745

days old

coreboot-gerrit@coreboot.org

9 comments

3 participants

tags (0)

participants (3)

Angel Pons (Code Review)
Felix Held (Code Review)
HAOUAS Elyes (Code Review)