Attention is currently required from: Arthur Heymans, Nico Huber, ron minnich. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62574 )
Change subject: cbfstool/linux_trampoline: Fill the ACPI RSDP entry ......................................................................
Patch Set 4:
(15 comments)
File util/cbfstool/linux_trampoline.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143065): https://review.coreboot.org/c/coreboot/+/62574/comment/c4d21478_03568cdc PS4, Line 6: 0xcb, 0x0f, 0x84, 0xc5, 0x00, 0x00, 0x00, 0x8b, 0x59, 0x04, 0x01, 0xcb, 0x8b, 0x49, 0x14, 0x83, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143065): https://review.coreboot.org/c/coreboot/+/62574/comment/e06d9d34_a2e45451 PS4, Line 6: 0xcb, 0x0f, 0x84, 0xc5, 0x00, 0x00, 0x00, 0x8b, 0x59, 0x04, 0x01, 0xcb, 0x8b, 0x49, 0x14, 0x83, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143065): https://review.coreboot.org/c/coreboot/+/62574/comment/6909c229_ecade045 PS4, Line 11: 0xe8, 0x01, 0x09, 0x00, 0xbf, 0xd0, 0x02, 0x09, 0x00, 0x83, 0xf8, 0x00, 0x74, 0x2f, 0x83, 0x7f, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143065): https://review.coreboot.org/c/coreboot/+/62574/comment/7397f78d_290b77cc PS4, Line 11: 0xe8, 0x01, 0x09, 0x00, 0xbf, 0xd0, 0x02, 0x09, 0x00, 0x83, 0xf8, 0x00, 0x74, 0x2f, 0x83, 0x7f, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143065): https://review.coreboot.org/c/coreboot/+/62574/comment/84044074_8a6675a6 PS4, Line 13: 0xe8, 0x83, 0x3b, 0x43, 0x75, 0x12, 0x8b, 0x43, 0x08, 0xa3, 0x70, 0x00, 0x09, 0x00, 0x8b, 0x43, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143065): https://review.coreboot.org/c/coreboot/+/62574/comment/1090d73a_943f96ca PS4, Line 13: 0xe8, 0x83, 0x3b, 0x43, 0x75, 0x12, 0x8b, 0x43, 0x08, 0xa3, 0x70, 0x00, 0x09, 0x00, 0x8b, 0x43, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143065): https://review.coreboot.org/c/coreboot/+/62574/comment/dfbc6b58_a5daf403 PS4, Line 14: 0x0c, 0xa3, 0x74, 0x00, 0x09, 0x00, 0x74, 0x05, 0x83, 0x3b, 0x12, 0x75, 0x00, 0x03, 0x5b, 0x04, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143065): https://review.coreboot.org/c/coreboot/+/62574/comment/386b01bf_e6605680 PS4, Line 14: 0x0c, 0xa3, 0x74, 0x00, 0x09, 0x00, 0x74, 0x05, 0x83, 0x3b, 0x12, 0x75, 0x00, 0x03, 0x5b, 0x04, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143065): https://review.coreboot.org/c/coreboot/+/62574/comment/1db7bcb4_25fe1315 PS4, Line 15: 0x49, 0x0f, 0x85, 0x78, 0xff, 0xff, 0xff, 0xb8, 0x00, 0x00, 0x04, 0x00, 0xc7, 0x40, 0x10, 0xff, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143065): https://review.coreboot.org/c/coreboot/+/62574/comment/cae46dbe_f0b8f395 PS4, Line 15: 0x49, 0x0f, 0x85, 0x78, 0xff, 0xff, 0xff, 0xb8, 0x00, 0x00, 0x04, 0x00, 0xc7, 0x40, 0x10, 0xff, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143065): https://review.coreboot.org/c/coreboot/+/62574/comment/642bf848_4806048a PS4, Line 16: 0xff, 0x00, 0x00, 0xc7, 0x40, 0x14, 0x00, 0x9b, 0xcf, 0x00, 0xc7, 0x40, 0x18, 0xff, 0xff, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143065): https://review.coreboot.org/c/coreboot/+/62574/comment/4ef125f4_c3207c8e PS4, Line 16: 0xff, 0x00, 0x00, 0xc7, 0x40, 0x14, 0x00, 0x9b, 0xcf, 0x00, 0xc7, 0x40, 0x18, 0xff, 0xff, 0x00, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143065): https://review.coreboot.org/c/coreboot/+/62574/comment/2bb52ebb_b8c9f873 PS4, Line 17: 0x00, 0xc7, 0x40, 0x1c, 0x00, 0x93, 0xcf, 0x00, 0xc6, 0x00, 0x2b, 0x89, 0x40, 0x02, 0x0f, 0x01, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143065): https://review.coreboot.org/c/coreboot/+/62574/comment/2b420f64_6304325a PS4, Line 17: 0x00, 0xc7, 0x40, 0x1c, 0x00, 0x93, 0xcf, 0x00, 0xc6, 0x00, 0x2b, 0x89, 0x40, 0x02, 0x0f, 0x01, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143065): https://review.coreboot.org/c/coreboot/+/62574/comment/3ccf7061_35630588 PS4, Line 18: 0x10, 0xbe, 0x00, 0x00, 0x09, 0x00, 0xff, 0x25, 0x14, 0x02, 0x09, 0x00, 0xf4, 0xeb, 0xfd please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)