Attention is currently required from: Michał Żygowski, Michał Kopeć, Michael Niewöhner. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62498 )
Change subject: mb/clevo/tgl-u: Add Clevo NV41 Tiger Lake laptop support ......................................................................
Patch Set 1:
(12 comments)
File src/mainboard/clevo/tgl-u/Kconfig:
https://review.coreboot.org/c/coreboot/+/62498/comment/4f2cfc35_cda962e6 PS1, Line 6: BOARD_CLEVO_TGL_U_COMMON Move this to the top please
https://review.coreboot.org/c/coreboot/+/62498/comment/4f0f9ee4_c4a3c654 PS1, Line 43: config MAINBOARD_FAMILY : string : default "Not Applicable" # Match stock firmware Remove
File src/mainboard/clevo/tgl-u/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/62498/comment/930559a0_4b418f1d PS1, Line 5: select BOARD_CLEVO_NV4X_BASE We don't do selects in this file, only in Kconfig. See clevo/cml-u/Kconfig.
File src/mainboard/clevo/tgl-u/board.fmd:
PS1: Why is this needed?
File src/mainboard/clevo/tgl-u/mainboard.c:
PS1: Rename this file to ramstage.c
File src/mainboard/clevo/tgl-u/memory.c:
PS1: Rename this file to romstage.c
File src/mainboard/clevo/tgl-u/romstage.c:
PS1: Move this file to variant/nv4x/
File src/mainboard/clevo/tgl-u/variants/baseboard/devicetree.cb:
PS1: We don't use a baseboard directory in the clevo mainboards. The "baseboard" directory is just the root directory of it, so mainboard/clevo/tgl-u/. Please move it to there.
File src/mainboard/clevo/tgl-u/variants/baseboard/include/baseboard/variants.h:
PS1: Same here. Move the include folder to mainboard/clevo/tgl-u. See the other Clevos how it is done there.
File src/mainboard/clevo/tgl-u/variants/nv4x/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/62498/comment/64c61419_76f6b6f5 PS1, Line 3: gpio.c Use early_gpio.c here
File src/mainboard/clevo/tgl-u/variants/nv4x/gpio.c:
https://review.coreboot.org/c/coreboot/+/62498/comment/67e233f8_ac799b78 PS1, Line 242: static const struct pad_config early_gpio_table[] = { : PAD_CFG_NF(GPP_C20, UP_20K, DEEP, NF1), /* UART2_RXD */ : PAD_CFG_NF(GPP_C21, UP_20K, DEEP, NF1), /* UART2_TXD */ : PAD_CFG_TERM_GPO(GPP_U4, 0, NONE, DEEP), /* DGPU_RST#_PCH */ : PAD_CFG_TERM_GPO(GPP_U5, 0, NONE, DEEP), /* DGPU_PWR_EN */ : }; Move this to early_gpio.c
https://review.coreboot.org/c/coreboot/+/62498/comment/0bd00988_fbfdea20 PS1, Line 255: const struct pad_config *variant_early_gpio_table(size_t *num) : { : *num = ARRAY_SIZE(early_gpio_table); : return early_gpio_table; : } See clevo/cml-u/variants/l140cu/romstage.c how we do GPIO configuration there.
-
Felix Singer (Code Review)