Attention is currently required from: Arthur Heymans, Cliff Huang, Lance Zhao, Martin L Roth, Naresh Solanki, Patrick Rudolph, Paul Menzel, Tim Wawrzynczak.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77884?usp=email )
Change subject: acpi: Add IO Remapping Table structures
......................................................................
Patch Set 6:
(2 comments)
Commit Message:
PS6:
Which specification is this code based on? I found `DEN0049E_IO_Remapping_Table.pdf` (non-confidential document) on the ARM website, but I'm not sure if this is the same document you've used.
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/77884/comment/0489fc52_46d7dc6f :
PS6, Line 92: IORT, /* Input Output Remapping Table */
I can't find the specification for this table in the ACPI specifications, only in ARM document `DEN0049E_IO_Remapping_Table.pdf`. I think it should be added to the second group ("Additional proprietary tables used by coreboot") instead.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77884?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4e8e3323caa714a56882939914cac510bf95d30b
Gerrit-Change-Number: 77884
Gerrit-PatchSet: 6
Gerrit-Owner: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Comment-Date: Mon, 20 Nov 2023 09:35:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment