Attention is currently required from: Furquan Shaikh, Sumeet R Pawnikar.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52859 )
Change subject: mb/google/brya: enable DPTF functionality for brya
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/52859/comment/eecff601_7ba43a54
PS1, Line 123: chip drivers/intel/dptf
As per our understanding, these changes are required as under baseboard changes for brya variants an […]
Hi Sumeet, having gone through 2 programs with this approach (volteer & dedede), I think I'd like to try keeping the DPTF parameters in each overridetree instead of the baseboard.
Several reasons for this:
1) Separate tables depending on FW_CONFIG, see CB:52495, I think this makes it harder to understand lindar's tables
2) Syntax differences between devicetree & override can cause unintended behavior (dedede had to fix several variants with this issue)
3) CB:46874, awkward to disable active policy for fanless devices
WDYT?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52859
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33266c85aa30869466034ccbab04a3c7820ae2b0
Gerrit-Change-Number: 52859
Gerrit-PatchSet: 1
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Comment-Date: Tue, 04 May 2021 16:38:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment