Attention is currently required from: Furquan Shaikh, Sumeet R Pawnikar.

View Change

1 comment:

• File src/mainboard/google/brya/variants/baseboard/devicetree.cb:

  • Patch Set #1, Line 123: chip drivers/intel/dptf

    As per our understanding, these changes are required as under baseboard changes for brya variants an […]

    Hi Sumeet, having gone through 2 programs with this approach (volteer & dedede), I think I'd like to try keeping the DPTF parameters in each overridetree instead of the baseboard.

    Several reasons for this:
    1) Separate tables depending on FW_CONFIG, see CB:52495, I think this makes it harder to understand lindar's tables

    2) Syntax differences between devicetree & override can cause unintended behavior (dedede had to fix several variants with this issue)

    3) CB:46874, awkward to disable active policy for fanless devices

    WDYT?

To view, visit change 52859. To unsubscribe, or for help writing mail filters, visit settings.