Attention is currently required from: Subrata Banik, Jérémy Compostella, Paul Menzel, Sridhar Siricilla.
Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74577 )
Change subject: soc/intel/cse_lite: Back up PSR data during CSE FW downgrade
......................................................................
Patch Set 32:
(3 comments)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/74577/comment/d6eadd78_c80d6948
PS27, Line 145: struct psr_heci_fw_downgrade_backup_req {
: struct psr_heci_header header;
: } __packed;
Why do you need to define this ?
this is to keep the code in sync with the HECI API definition for better readability of the code
https://review.coreboot.org/c/coreboot/+/74577/comment/3781f36b_4058132c
PS27, Line 153: sizeof(struct psr_heci_fw_downgrade_backup_res)
is there any issue using sizeof with structure ?
Done
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/74577/comment/68bb0819_66fccc50
PS28, Line 142: static enum cb_err cse_send_backup_psr_cmd(struct psr_heci_fw_downgrade_backup_res *res)
at the moment this function is only called during downgrade. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74577
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I135d197b5df0a20def823fe615860b5ead4391f8
Gerrit-Change-Number: 74577
Gerrit-PatchSet: 32
Gerrit-Owner: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.corp-partner.google.com
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-CC: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Wed, 03 May 2023 06:31:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anil Kumar K
anil.kumar.k@intel.com
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-MessageType: comment