Change in ...coreboot[master]: superio/ite: Add IT8786E-I - coreboot-gerrit

13 May 2019


      Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30335 )
Change subject: superio/ite: Add IT8786E-I
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/#/c/30335/6/src/superio/ite/it8786e/superio.c 
File src/superio/ite/it8786e/superio.c:
https://review.coreboot.org/#/c/30335/6/src/superio/ite/it8786e/superio.c@62 
PS6, Line 62: &ops
...
these should be all NULL, since no LDN-specific override is needed here. […]
Done
https://review.coreboot.org/#/c/30335/6/src/superio/ite/it8786e/superio.c@11... 
PS6, Line 112: &pnp_ops
...
this needs to be &ops
Thank You Felix, I overlooked that when rebasing.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30335
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7317da6a72db64f95f9a790ef96ed7a5f93b3aea
Gerrit-Change-Number: 30335
Gerrit-PatchSet: 7
Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Piotr Król piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Comment-Date: Mon, 13 May 2019 08:57:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment