Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/29543
Change subject: mb/lenovo/*/dsdt: Move mainboard-specific defines out of ec.asl ......................................................................
mb/lenovo/*/dsdt: Move mainboard-specific defines out of ec.asl
Most Lenovo mainboards define their own specific defines in dsdt.asl. Let's make it consistent across all Lenovo mainboards.
Tested - builds fine.
Change-Id: I03fbeb09b25e42af2dfbb220c0f726e6abb73673 Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/lenovo/t430/acpi/ec.asl M src/mainboard/lenovo/t430/dsdt.asl M src/mainboard/lenovo/x131e/acpi/ec.asl M src/mainboard/lenovo/x131e/dsdt.asl 4 files changed, 12 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/29543/1
diff --git a/src/mainboard/lenovo/t430/acpi/ec.asl b/src/mainboard/lenovo/t430/acpi/ec.asl index 3c7f89d..63d6a82 100644 --- a/src/mainboard/lenovo/t430/acpi/ec.asl +++ b/src/mainboard/lenovo/t430/acpi/ec.asl @@ -13,10 +13,4 @@ * GNU General Public License for more details. */
-#define BRIGHTNESS_UP _SB.PCI0.GFX0.INCB -#define BRIGHTNESS_DOWN _SB.PCI0.GFX0.DECB -#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0 -#define EC_LENOVO_H8_ME_WORKAROUND 1 -#define THINKPAD_EC_GPE 17 - #include <ec/lenovo/h8/acpi/ec.asl> diff --git a/src/mainboard/lenovo/t430/dsdt.asl b/src/mainboard/lenovo/t430/dsdt.asl index dff8dcd..fd7d1bd 100644 --- a/src/mainboard/lenovo/t430/dsdt.asl +++ b/src/mainboard/lenovo/t430/dsdt.asl @@ -15,6 +15,12 @@ * GNU General Public License for more details. */
+#define THINKPAD_EC_GPE 17 +#define BRIGHTNESS_UP _SB.PCI0.GFX0.INCB +#define BRIGHTNESS_DOWN _SB.PCI0.GFX0.DECB +#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0 +#define EC_LENOVO_H8_ME_WORKAROUND 1 + DefinitionBlock( "dsdt.aml", "DSDT", diff --git a/src/mainboard/lenovo/x131e/acpi/ec.asl b/src/mainboard/lenovo/x131e/acpi/ec.asl index 02a9d2b..acbb778 100644 --- a/src/mainboard/lenovo/x131e/acpi/ec.asl +++ b/src/mainboard/lenovo/x131e/acpi/ec.asl @@ -15,10 +15,4 @@ * GNU General Public License for more details. */
-#define THINKPAD_EC_GPE 22 -#define BRIGHTNESS_UP _SB.PCI0.GFX0.INCB -#define BRIGHTNESS_DOWN _SB.PCI0.GFX0.DECB -#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0 -#define EC_LENOVO_H8_ME_WORKAROUND 1 - #include <ec/lenovo/h8/acpi/ec.asl> diff --git a/src/mainboard/lenovo/x131e/dsdt.asl b/src/mainboard/lenovo/x131e/dsdt.asl index cd1af34..4cad57a 100644 --- a/src/mainboard/lenovo/x131e/dsdt.asl +++ b/src/mainboard/lenovo/x131e/dsdt.asl @@ -16,6 +16,12 @@ * GNU General Public License for more details. */
+#define THINKPAD_EC_GPE 22 +#define BRIGHTNESS_UP _SB.PCI0.GFX0.INCB +#define BRIGHTNESS_DOWN _SB.PCI0.GFX0.DECB +#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0 +#define EC_LENOVO_H8_ME_WORKAROUND 1 + DefinitionBlock( "dsdt.aml", "DSDT",