Change in coreboot[master]: mb/emulation/qemu-q35: Increase max size of ACPI tables

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Duncan Laurie (Code Review)

25 Mar 2020 25 Mar '20

6:27 p.m.

Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39833 )

Change subject: mb/emulation/qemu-q35: Increase max size of ACPI tables ......................................................................

mb/emulation/qemu-q35: Increase max size of ACPI tables

When the TPM is enabled in QEMU the fw_cfg interface will return ~200KiB of ACPI tables, so this needs to be increased from the default in order to be able to boot.

Change-Id: I21980aace8e86e636f5ae7b55148f4c31404edba Signed-off-by: Duncan Laurie dlaurie@google.com --- M src/mainboard/emulation/qemu-q35/Kconfig 1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/39833/1

diff --git a/src/mainboard/emulation/qemu-q35/Kconfig b/src/mainboard/emulation/qemu-q35/Kconfig index ee430d0..71841fb 100644 --- a/src/mainboard/emulation/qemu-q35/Kconfig +++ b/src/mainboard/emulation/qemu-q35/Kconfig @@ -51,6 +51,11 @@ hex default 0xb0000000

+# fw_cfg tables can be larger than the default when TPM is enabled +config MAX_ACPI_TABLE_SIZE_KB + int + default 224 + # Skip the first 64KiB as coreboot table pointer is installed # at address 0 config DCACHE_RAM_BASE

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

Furquan Shaikh (Code Review)

25 Mar 25 Mar

6:43 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39833 )

Change subject: mb/emulation/qemu-q35: Increase max size of ACPI tables ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I21980aace8e86e636f5ae7b55148f4c31404edba Gerrit-Change-Number: 39833 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 25 Mar 2020 17:43:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

9:36 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39833 )

Change subject: mb/emulation/qemu-q35: Increase max size of ACPI tables ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/39833/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39833/1//COMMIT_MSG@12 PS1, Line 12: Please add the command line used for testing.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I21980aace8e86e636f5ae7b55148f4c31404edba Gerrit-Change-Number: 39833 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 25 Mar 2020 20:36:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Duncan Laurie (Code Review)

26 Mar 26 Mar

10:05 p.m.

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39833 )

Change subject: mb/emulation/qemu-q35: Increase max size of ACPI tables ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39833/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39833/1//COMMIT_MSG@12 PS1, Line 12:

...

Please add the command line used for testing.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/39833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I21980aace8e86e636f5ae7b55148f4c31404edba Gerrit-Change-Number: 39833 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 26 Mar 2020 21:05:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Paul Menzel (Code Review)

27 Mar 27 Mar

1:53 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39833 )

Change subject: mb/emulation/qemu-q35: Increase max size of ACPI tables ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39833/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39833/1//COMMIT_MSG@12 PS1, Line 12:

...

Done

You added it to the other commit message, and I wouldn’t mind to have it here too. But I am fine with this as is.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I21980aace8e86e636f5ae7b55148f4c31404edba Gerrit-Change-Number: 39833 Gerrit-PatchSet: 2 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 27 Mar 2020 12:53:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Duncan Laurie dlaurie@chromium.org Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Duncan Laurie (Code Review)

31 Mar 31 Mar

12:20 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Paul Menzel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39833

to look at the new patch set (#3).

Change subject: mb/emulation/qemu-q35: Increase max size of ACPI tables ......................................................................

mb/emulation/qemu-q35: Increase max size of ACPI tables

When the TPM is enabled in QEMU the fw_cfg interface will return ~200KiB of ACPI tables, so this needs to be increased from the default in order to be able to boot.

This is seen when using a TPM with qemu as it will hang when processing the fw_cfg tables.

qemu-system-x86_64 \ -machine q35 -enable-kvm -vga virtio -serial stdio \ -drive 'id=hd,file=disk.bin' -bios coreboot.rom \ -chardev 'socket,id=swtpm,path=/tmp/swtpm/swtpm-sock' \ -tpmdev 'emulator,id=tpm0,chardev=swtpm' \ -device 'tpm-tis,tpmdev=tpm0'

Change-Id: I21980aace8e86e636f5ae7b55148f4c31404edba Signed-off-by: Duncan Laurie dlaurie@google.com --- M src/mainboard/emulation/qemu-q35/Kconfig 1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/39833/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/39833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I21980aace8e86e636f5ae7b55148f4c31404edba Gerrit-Change-Number: 39833 Gerrit-PatchSet: 3 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

12:39 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39833 )

Change subject: mb/emulation/qemu-q35: Increase max size of ACPI tables ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I21980aace8e86e636f5ae7b55148f4c31404edba Gerrit-Change-Number: 39833 Gerrit-PatchSet: 3 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 31 Mar 2020 10:39:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

12:40 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39833 )

Change subject: mb/emulation/qemu-q35: Increase max size of ACPI tables ......................................................................

mb/emulation/qemu-q35: Increase max size of ACPI tables

When the TPM is enabled in QEMU the fw_cfg interface will return ~200KiB of ACPI tables, so this needs to be increased from the default in order to be able to boot.

This is seen when using a TPM with qemu as it will hang when processing the fw_cfg tables.

Change-Id: I21980aace8e86e636f5ae7b55148f4c31404edba Signed-off-by: Duncan Laurie dlaurie@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39833 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/emulation/qemu-q35/Kconfig 1 file changed, 5 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/39833 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I21980aace8e86e636f5ae7b55148f4c31404edba Gerrit-Change-Number: 39833 Gerrit-PatchSet: 4 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1690

days inactive

1696

days old

coreboot-gerrit@coreboot.org

7 comments

4 participants

tags (0)

participants (4)

Duncan Laurie (Code Review)
Furquan Shaikh (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)