Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Andrey Petrov, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49798 )
Change subject: drivers/intel/fsp2_0: Add meaningful ERROR message
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49798/comment/091402fa_2f635b3a
PS1, Line 12: suspend_stress_test
P.S. […]
added a note there as well
File src/drivers/intel/fsp2_0/memory_init.c:
https://review.coreboot.org/c/coreboot/+/49798/comment/659a8240_63acaa93
PS1, Line 39: 9.2
I don't think adding chapter # is a good idea. The chapter number is correct for FSP2. […]
Ack
https://review.coreboot.org/c/coreboot/+/49798/comment/ee5421c7_13f70cef
PS1, Line 51: Failed
Add ERROR: here as well?
Ack
https://review.coreboot.org/c/coreboot/+/49798/comment/3033285f_e82d48be
PS1, Line 68: Failed
And here?
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49798
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64717ce0412d43697f42ea2122b932037d28dd48
Gerrit-Change-Number: 49798
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 22 Jan 2021 04:54:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment