Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45570 )
Change subject: mb/google/dedede/var/drawcia: Enable EC keyboard backlight ......................................................................
mb/google/dedede/var/drawcia: Enable EC keyboard backlight
BUG=b:168847046 TEST=emerge-dedede coreboot chromeos-bootimage
Signed-off-by: Wisley Chen wisley.chen@quantatw.com Change-Id: I16ed22aa5e270ad2d5c964764cc134b72941d4e4 --- M src/mainboard/google/dedede/variants/drawcia/include/variant/ec.h 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/45570/1
diff --git a/src/mainboard/google/dedede/variants/drawcia/include/variant/ec.h b/src/mainboard/google/dedede/variants/drawcia/include/variant/ec.h index 08870e0..27c930d 100644 --- a/src/mainboard/google/dedede/variants/drawcia/include/variant/ec.h +++ b/src/mainboard/google/dedede/variants/drawcia/include/variant/ec.h @@ -5,4 +5,7 @@
#include <baseboard/ec.h>
+/* Enable Keyboard Backlight in ACPI */ +#define EC_ENABLE_KEYBOARD_BACKLIGHT + #endif
Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45570 )
Change subject: mb/google/dedede/var/drawcia: Enable EC keyboard backlight ......................................................................
Patch Set 1: Code-Review+1
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45570 )
Change subject: mb/google/dedede/var/drawcia: Enable EC keyboard backlight ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45570 )
Change subject: mb/google/dedede/var/drawcia: Enable EC keyboard backlight ......................................................................
mb/google/dedede/var/drawcia: Enable EC keyboard backlight
BUG=b:168847046 TEST=emerge-dedede coreboot chromeos-bootimage
Signed-off-by: Wisley Chen wisley.chen@quantatw.com Change-Id: I16ed22aa5e270ad2d5c964764cc134b72941d4e4 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45570 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Henry Sun henrysun@google.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/variants/drawcia/include/variant/ec.h 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved Henry Sun: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/dedede/variants/drawcia/include/variant/ec.h b/src/mainboard/google/dedede/variants/drawcia/include/variant/ec.h index 08870e0..27c930d 100644 --- a/src/mainboard/google/dedede/variants/drawcia/include/variant/ec.h +++ b/src/mainboard/google/dedede/variants/drawcia/include/variant/ec.h @@ -5,4 +5,7 @@
#include <baseboard/ec.h>
+/* Enable Keyboard Backlight in ACPI */ +#define EC_ENABLE_KEYBOARD_BACKLIGHT + #endif
-
Chen Wisley (Code Review) -
Henry Sun (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Patrick Georgi (Code Review)