Attention is currently required from: Paul Menzel, Angel Pons, Jonathon Hall, Felix Held.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74903 )
Change subject: drivers/pc80/rtc/mc146818rtc.c: Add Kconfig for RTC CMOS base addresses
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74903/comment/bf2b3296_7a2343a1
PS2, Line 17: and the EC BRAM bank 1.
That's fine, I just felt like I usually get asked to add more explanation of why someone might want […]
Ack
File src/drivers/pc80/rtc/Kconfig:
https://review.coreboot.org/c/coreboot/+/74903/comment/7f2163aa_3b51cb66
PS2, Line 9: depends on DRIVERS_MC146818
Some files (drivers/pc80/rtc/option.c,post.c) include mc146818. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74903
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie44e5f5191c66f44e2df8ea0ff58a860be88bfcf
Gerrit-Change-Number: 74903
Gerrit-PatchSet: 3
Gerrit-Owner: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 02 May 2023 17:13:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Jonathon Hall
jonathon.hall@puri.sm
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment