[XS] Change in coreboot[main]: src/arch/x86/Makefile.inc: Do not pass CPPFLAGS to linker - coreboot-gerrit

22 Nov 2023


      Attention is currently required from: Srinivas Hegde.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79218?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: src/arch/x86/Makefile.inc: Do not pass CPPFLAGS to linker
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: 
The '$$(call src-to-obj,$1,$$(1).ld):' target does the CPP so it can be omitted here.
The commit message is not correct though. It's not erronously using CPPFLAGS, it's just superfluous.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/79218?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia3cd51be6be252aa796191cf0d2cd91d393c8878
Gerrit-Change-Number: 79218
Gerrit-PatchSet: 2
Gerrit-Owner: Srinivas Hegde srinivashegde@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: Patrick Georgi patrick@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Srinivas Hegde srinivashegde@google.com
Gerrit-Comment-Date: Wed, 22 Nov 2023 13:48:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment