Attention is currently required from: Sean Rhodes. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55128 )
Change subject: src/mainboard: Add Star Labs labtop series ......................................................................
Patch Set 12: Code-Review+2
(1 comment)
File Documentation/mainboard/starlabs/labtop.md:
https://review.coreboot.org/c/coreboot/+/55128/comment/c01b1299_4638fbc4 PS9, Line 1: # Star Labs LabTop : : ## Specs : : - CPU (full processor specs available at https://ark.intel.com) : - Intel i7-10710U (Comet Lake) : - Intel i3-10110U (Comet Lake) : - Intel i7-8550u (Kaby Lake Refresh) : - EC : - ITE IT8987E : - Backlit Keyboard, with standard PS/2 keycodes and SCI hotkeys : - Battery : - Charger, using AC adapter or USB-C PD : - Suspend / resume : - GPU : - Intel UHD Graphics 620 : - GOP driver is recommended, VBT is provided : - eDP 13-inch 1920x1080 LCD : - HDMI video : - USB-C DisplayPort video : - Memory : - 16GB on-board for Comet Lake platforms[^1] : - 8GB on-board for Kaby Lake Refresh platform. : - Networking : - AX201 CNVi WiFi / Bluetooth soldered to PCBA (Comet Lake) : - 8265 PCIe WiFi / Bluetooth soldered to PCBA (Kaby Lake Refresh) : - Sound : - Realtek ALC256 : - Internal speakers : - Internal microphone : - Combined headphone / microphone 3.5-mm jack : - HDMI audio : - USB-C DisplayPort audio : - Storage : - M.2 PCIe SSD : - RTS5129 MicroSD card reader : - USB : - 1280x720 CCD camera : - USB 3.1 Gen 2 Type-C (left) : - USB 3.1 Gen 2 Type-A (left) : - USB 3.1 Gen 1 Type-A (right) : : [^1] The Comet Lake PCB supports multiple memory variations that are based on hardware configuration resistors see `src/mainboard/starlabs/labtop/variants/cml/romstage.c` : : ## Building coreboot : : ### Preliminaries : : Prior to building coreboot the following files are required: : : Comet Lake and Kaby Lake configurations: : - Intel Flash Descriptor file (descriptor.bin) : - Intel Management Engine firmware (me.bin) : : Comet Lake configuration only: : - ITE IT8987E firmware (it8987-x.xx.bin) : : All Star Labs platforms: : - Splash screen image in Windows 3.1 BMP format (Logo.bmp) : : These files exist in the correct location in the StarLabsLtd/blobs repo on GitHub which is used in place of the standard 3rdparty/blobs repo. : : ### Build : : The following commands will build a working image: : : ##### LabTop Mk IV (Comet Lake) : : ```bash : make distclean : make defconfig KBUILD_DEFCONFIG=configs/config.starlabs_labtop_cml : make : ``` : : ##### LabTop Mk III (Kaby Lake) : : ```bash : make distclean : make defconfig KBUILD_DEFCONFIG=configs/config.starlabs_labtop_kbl : make : ``` : : ## Flashing coreboot : : ```eval_rst : +---------------------+------------+ : | Type | Value | : +=====================+============+ : | Socketed flash | no | : +---------------------+------------+ : | Vendor | Winbond | : +---------------------+------------+ : | Model | 25Q128JVSQ | : +---------------------+------------+ : | Size | 16 MiB | : +---------------------+------------+ : | Package | SOIC-8 | : +---------------------+------------+ : | Internal flashing | yes | : +---------------------+------------+ : | External flashing | no | : +---------------------+------------+ some reason you removed this?
-
Tim Wawrzynczak (Code Review)