Attention is currently required from: Furquan Shaikh, Karthik Ramasubramanian.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55599 )
Change subject: mb/google/guybrush: Add support to override dxio port descriptors
......................................................................
Patch Set 4: Code-Review-2
(1 comment)
Patchset:
PS4:
This isn't currently needed since we're moving the PCIe resets out of the dxio descriptors.
Following my understanding of best practices, I think that this should probably be abandoned until it's actually needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55599
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib98c6da63f091eefb8302245e01ec4152438ccc7
Gerrit-Change-Number: 55599
Gerrit-PatchSet: 4
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 22 Jun 2021 16:08:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment