Attention is currently required from: Joel Linn, Nico Huber.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81426?usp=email )
Change subject: superio/ite: Add special fan vectors
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
currently, these fan vectors are being programmed even if they are unset in the mainboard devicetree, as long as the SoC supports it. We might want to have a separate Kconfig to enable the use/programming, and have mainboards select that.
So in env_ctrl.c, guard based on SUPERIO_ITE_ENV_CTRL_USE_FAN_VECTOR, rather than SUPERIO_ITE_ENV_CTRL_HAS_FAN_VECTOR, and have the former depend on the latter
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81426?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I93df2b5652fc3fde775b6161fa5bebc4a34d5e94
Gerrit-Change-Number: 81426
Gerrit-PatchSet: 6
Gerrit-Owner: Joel Linn
jl_coreboot@conductive.de
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Joel Linn
jl_coreboot@conductive.de
Gerrit-Comment-Date: Fri, 29 Mar 2024 14:57:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment