Change in coreboot[master]: mb/google/zork: Update SPD table for Shuboz

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Kane Chen (Code Review)

24 Nov 2020 24 Nov '20

1:48 a.m.

Kane Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47902 )

Change subject: mb/google/zork: Update SPD table for Shuboz ......................................................................

mb/google/zork: Update SPD table for Shuboz

Add SPD support in Shuboz memory table as follow: 1. MICRON MT40A512M16TB-062E:J 2. HYNIX H5AN8G6NCJR-XNC 3. MICRON MT40A1G16KD-062E:E 4. SAMSUNG K4AAG165WA-BCWE

BUG=b:none BRANCH=zork TEST=emerge-zork coreboot

Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I5f5f875daab58343f1cc8a9327ea128ba5e1f050 --- M src/mainboard/google/zork/variants/shuboz/spd/Makefile.inc M src/mainboard/google/zork/variants/shuboz/spd/dram_id.generated.txt M src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt 3 files changed, 13 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/47902/1

diff --git a/src/mainboard/google/zork/variants/shuboz/spd/Makefile.inc b/src/mainboard/google/zork/variants/shuboz/spd/Makefile.inc index 3edeb96..87b5aa97 100644 --- a/src/mainboard/google/zork/variants/shuboz/spd/Makefile.inc +++ b/src/mainboard/google/zork/variants/shuboz/spd/Makefile.inc @@ -1,5 +1,8 @@ ## SPDX-License-Identifier: GPL-2.0-or-later ## This is an auto-generated file. Do not edit!! -## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.

-SPD_SOURCES = ddr4-spd-empty.hex +SPD_SOURCES = +SPD_SOURCES += ddr4-spd-1.hex # ID = 0(0b0000) Parts = MT40A512M16TB-062E:J +SPD_SOURCES += ddr4-spd-1.hex # ID = 1(0b0001) Parts = H5AN8G6NCJR-XNC +SPD_SOURCES += ddr4-spd-7.hex # ID = 2(0b0010) Parts = MT40A1G16KD-062E:E +SPD_SOURCES += ddr4-spd-7.hex # ID = 3(0b0011) Parts = K4AAG165WA-BCWE diff --git a/src/mainboard/google/zork/variants/shuboz/spd/dram_id.generated.txt b/src/mainboard/google/zork/variants/shuboz/spd/dram_id.generated.txt index fa24790..8019b2e 100644 --- a/src/mainboard/google/zork/variants/shuboz/spd/dram_id.generated.txt +++ b/src/mainboard/google/zork/variants/shuboz/spd/dram_id.generated.txt @@ -1 +1,5 @@ DRAM Part Name ID to assign +MT40A512M16TB-062E:J 0 (0000) +H5AN8G6NCJR-XNC 1 (0001) +MT40A1G16KD-062E:E 2 (0010) +K4AAG165WA-BCWE 3 (0011) diff --git a/src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt b/src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt index 106a705..f2240fd 100644 --- a/src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt +++ b/src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt @@ -7,3 +7,7 @@ # See util/spd_tools/ddr4/README.md for more details and instructions.

# Part Name, Fixed ID (optional) +MT40A512M16TB-062E:E, 0 +H5AN8G6NCJR-XNC, 1 +MT40A1G16KD-062E:E, 2 +K4AAG165WA-BCWE, 3

Attachments:

attachment.htm (text/html — 5.1 KB)

Show replies by date

Furquan Shaikh (Code Review)

24 Nov 24 Nov

3:40 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47902 )

Change subject: mb/google/zork: Update SPD table for Shuboz ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47902/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt:

https://review.coreboot.org/c/coreboot/+/47902/1/src/mainboard/google/zork/v... PS1, Line 10: 0 Why are IDs being assigned here? This is not required for new boards. You should let the tool assign the ID.

Kane Chen (Code Review)

25 Nov 25 Nov

5:18 a.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Rob Barnes, Eric Peers,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47902

to look at the new patch set (#2).

Change subject: mb/google/zork: Update SPD table for Shuboz ......................................................................

mb/google/zork: Update SPD table for Shuboz

Add memory table to "mem_parts_used.txt", and command to generate files: go build gen_part_id.go ./gen_part_id ../../../src/mainboard/google/zork/spd ../../../src/mainboard/google/zork/variants/shuboz/spd/ ../../../src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt

Shuboz memory table as follow: value Vendor Part number 0x00 MICRON MT40A512M16TB-062E:J 0x01 HYNIX H5AN8G6NCJR-XNC 0x02 MICRON MT40A1G16KD-062E:E 0x03 SAMSUNG K4AAG165WA-BCWE

BUG=b:none BRANCH=zork TEST=emerge-zork coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/47902/2

Kane Chen (Code Review)

5:45 a.m.

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47902 )

Change subject: mb/google/zork: Update SPD table for Shuboz ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47902/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt:

https://review.coreboot.org/c/coreboot/+/47902/1/src/mainboard/google/zork/v... PS1, Line 10: 0

...

Why are IDs being assigned here? This is not required for new boards. […]

Hi Furquan, Update memory table to commit, and we proto stage follow this memory table, so we add Fixed ID to generate SPD table. Thanks.

Furquan Shaikh (Code Review)

6:08 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47902 )

Change subject: mb/google/zork: Update SPD table for Shuboz ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47902/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt:

https://review.coreboot.org/c/coreboot/+/47902/1/src/mainboard/google/zork/v... PS1, Line 10: 0

...

Hi Furquan, […]

Is there a bug where this was discussed?

-- To view, visit https://review.coreboot.org/c/coreboot/+/47902 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f5f875daab58343f1cc8a9327ea128ba5e1f050 Gerrit-Change-Number: 47902 Gerrit-PatchSet: 2 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-Comment-Date: Wed, 25 Nov 2020 14:08:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-MessageType: comment

Kane Chen (Code Review)

7:20 p.m.

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47902 )

Change subject: mb/google/zork: Update SPD table for Shuboz ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47902/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt:

https://review.coreboot.org/c/coreboot/+/47902/1/src/mainboard/google/zork/v... PS1, Line 10: 0

...

Is there a bug where this was discussed?

Hi Furquan, We try remove Fixed ID to generate SPD table, the result is as follows: SPD_SOURCES = SPD_SOURCES += ddr4-spd-1.hex # ID = 0(0b0000) Parts = MT40A512M16TB-062E:J, H5AN8G6NCJR-XNC SPD_SOURCES += ddr4-spd-7.hex # ID = 1(0b0001) Parts = MT40A1G16KD-062E:E, K4AAG165WA-BCWE We think the result does not meet, so add Fixed ID to generate, or we need to change to this result? Thanks.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47902 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f5f875daab58343f1cc8a9327ea128ba5e1f050 Gerrit-Change-Number: 47902 Gerrit-PatchSet: 2 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-Comment-Date: Thu, 26 Nov 2020 03:20:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

7:28 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47902 )

Change subject: mb/google/zork: Update SPD table for Shuboz ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47902/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt:

https://review.coreboot.org/c/coreboot/+/47902/1/src/mainboard/google/zork/v... PS1, Line 10: 0

...

Hi Furquan, […]

Yes, the tool optimizes the ID allocation to ensure that we use generic SPDs and allocate the same ID for all parts with same characteristics. So, we should let the tool do the ID allocation and not use fixed IDs.

Have you already built devices with the fixed IDs here? Or is this being done for an upcoming build?

-- To view, visit https://review.coreboot.org/c/coreboot/+/47902 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f5f875daab58343f1cc8a9327ea128ba5e1f050 Gerrit-Change-Number: 47902 Gerrit-PatchSet: 2 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-Comment-Date: Thu, 26 Nov 2020 03:28:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-MessageType: comment

Ken Lu (Code Review)

26 Nov 26 Nov

1:21 a.m.

Ken Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47902 )

Change subject: mb/google/zork: Update SPD table for Shuboz ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47902/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt:

https://review.coreboot.org/c/coreboot/+/47902/1/src/mainboard/google/zork/v... PS1, Line 10: 0

...

Yes, the tool optimizes the ID allocation to ensure that we use generic SPDs and allocate the same I […]

Hi Furquan :

We had already build proto mainboard with this MEM table .

-- To view, visit https://review.coreboot.org/c/coreboot/+/47902 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f5f875daab58343f1cc8a9327ea128ba5e1f050 Gerrit-Change-Number: 47902 Gerrit-PatchSet: 2 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-Comment-Date: Thu, 26 Nov 2020 09:21:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-MessageType: comment

Kane Chen (Code Review)

11:49 p.m.

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47902 )

Change subject: mb/google/zork: Update SPD table for Shuboz ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/47902 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f5f875daab58343f1cc8a9327ea128ba5e1f050 Gerrit-Change-Number: 47902 Gerrit-PatchSet: 2 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-Comment-Date: Fri, 27 Nov 2020 07:49:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Rob Barnes (Code Review)

30 Nov 30 Nov

6:07 p.m.

Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47902 )

Change subject: mb/google/zork: Update SPD table for Shuboz ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47902/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt:

https://review.coreboot.org/c/coreboot/+/47902/1/src/mainboard/google/zork/v... PS1, Line 10: 0

...

Hi Furquan : […]

This is consuming two more ids than required. Probably fine since a proto board is already built. Going forward please allow the tool to assign ids.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47902 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f5f875daab58343f1cc8a9327ea128ba5e1f050 Gerrit-Change-Number: 47902 Gerrit-PatchSet: 2 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Bhanu Prakash Maiya bhanumaiya@google.com Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Randy I-Fan Wang ifanw@google.com Gerrit-Comment-Date: Tue, 01 Dec 2020 02:07:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Kane Chen kane_chen@pegatron.corp-partner.google.com Comment-In-Reply-To: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-MessageType: comment

Rob Barnes (Code Review)

6:08 p.m.

Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47902 )

Change subject: mb/google/zork: Update SPD table for Shuboz ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47902 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f5f875daab58343f1cc8a9327ea128ba5e1f050 Gerrit-Change-Number: 47902 Gerrit-PatchSet: 2 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Bhanu Prakash Maiya bhanumaiya@google.com Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Randy I-Fan Wang ifanw@google.com Gerrit-Comment-Date: Tue, 01 Dec 2020 02:08:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Kane Chen (Code Review)

10:22 p.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Bhanu Prakash Maiya, Rob Barnes, Eric Peers,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47902

to look at the new patch set (#3).

Change subject: mb/google/zork: Update SPD table for Shuboz ......................................................................

mb/google/zork: Update SPD table for Shuboz

Shuboz memory table as follow: value Vendor Part number 0x00 MICRON MT40A512M16TB-062E:J 0x01 HYNIX H5AN8G6NCJR-XNC 0x02 MICRON MT40A1G16KD-062E:E 0x03 SAMSUNG K4AAG165WA-BCWE

BUG=b:174528384 BRANCH=zork TEST=emerge-zork coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/47902/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/47902 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f5f875daab58343f1cc8a9327ea128ba5e1f050 Gerrit-Change-Number: 47902 Gerrit-PatchSet: 3 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Bhanu Prakash Maiya bhanumaiya@google.com Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Randy I-Fan Wang ifanw@google.com Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

2 Dec 2 Dec

2:41 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47902 )

Change subject: mb/google/zork: Update SPD table for Shuboz ......................................................................

mb/google/zork: Update SPD table for Shuboz

Shuboz memory table as follow: value Vendor Part number 0x00 MICRON MT40A512M16TB-062E:J 0x01 HYNIX H5AN8G6NCJR-XNC 0x02 MICRON MT40A1G16KD-062E:E 0x03 SAMSUNG K4AAG165WA-BCWE

BUG=b:174528384 BRANCH=zork TEST=emerge-zork coreboot

Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I5f5f875daab58343f1cc8a9327ea128ba5e1f050 Reviewed-on: https://review.coreboot.org/c/coreboot/+/47902 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Rob Barnes robbarnes@google.com --- M src/mainboard/google/zork/variants/shuboz/spd/Makefile.inc M src/mainboard/google/zork/variants/shuboz/spd/dram_id.generated.txt M src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt 3 files changed, 13 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Kane Chen: Looks good to me, but someone else must approve Rob Barnes: Looks good to me, approved

-SPD_SOURCES = ddr4-spd-empty.hex +SPD_SOURCES = +SPD_SOURCES += ddr4-spd-1.hex # ID = 0(0b0000) Parts = MT40A512M16TB-062E:J +SPD_SOURCES += ddr4-spd-1.hex # ID = 1(0b0001) Parts = H5AN8G6NCJR-XNC +SPD_SOURCES += ddr4-spd-7.hex # ID = 2(0b0010) Parts = MT40A1G16KD-062E:E +SPD_SOURCES += ddr4-spd-7.hex # ID = 3(0b0011) Parts = K4AAG165WA-BCWE diff --git a/src/mainboard/google/zork/variants/shuboz/spd/dram_id.generated.txt b/src/mainboard/google/zork/variants/shuboz/spd/dram_id.generated.txt index fa24790..8019b2e 100644 --- a/src/mainboard/google/zork/variants/shuboz/spd/dram_id.generated.txt +++ b/src/mainboard/google/zork/variants/shuboz/spd/dram_id.generated.txt @@ -1 +1,5 @@ DRAM Part Name ID to assign +MT40A512M16TB-062E:J 0 (0000) +H5AN8G6NCJR-XNC 1 (0001) +MT40A1G16KD-062E:E 2 (0010) +K4AAG165WA-BCWE 3 (0011) diff --git a/src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt b/src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt index 106a705..1faa641 100644 --- a/src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt +++ b/src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt @@ -7,3 +7,7 @@ # See util/spd_tools/ddr4/README.md for more details and instructions.

# Part Name, Fixed ID (optional) +MT40A512M16TB-062E:J, 0 +H5AN8G6NCJR-XNC, 1 +MT40A1G16KD-062E:E, 2 +K4AAG165WA-BCWE, 3

-- To view, visit https://review.coreboot.org/c/coreboot/+/47902 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f5f875daab58343f1cc8a9327ea128ba5e1f050 Gerrit-Change-Number: 47902 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Bhanu Prakash Maiya bhanumaiya@google.com Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com Gerrit-CC: Randy I-Fan Wang ifanw@google.com Gerrit-MessageType: merged

1445

days inactive

1453

days old

coreboot-gerrit@coreboot.org

12 comments

5 participants

tags (0)

participants (5)

Furquan Shaikh (Code Review)
Kane Chen (Code Review)
Ken Lu (Code Review)
Patrick Georgi (Code Review)
Rob Barnes (Code Review)