Attention is currently required from: Jason Glenesk, Martin Roth, Felix Held.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50466 )
Change subject: soc/amd: fully commonize clear_tvalid
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
File src/soc/amd/common/block/cpu/smm/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/50466/comment/c63ce7db_2bd4e538
PS5, Line 5: romstage-y += smm_helper.c
: postcar-y += smm_helper.c
*many
It's stoneyridge/memmap.c that's breaking and the function is called from smm_region() which is needed at those earlier times. I forget now why we explicitly clear tvalid, e.g. maybe we weren't guaranteed of it coming up clear.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50466
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90526a566a5fbc19a7368f90421067a6c716614e
Gerrit-Change-Number: 50466
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 10 Feb 2021 21:08:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment