Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39774 )
Change subject: soc/intel/tigerlake: Remove Jasper Lake SoC references ......................................................................
Patch Set 13:
(7 comments)
https://review.coreboot.org/c/coreboot/+/39774/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39774/5//COMMIT_MSG@7 PS5, Line 7: soc/intel/{tigerlake, jasperlake}: Split Jasper Lake SoC code from Tiger Lake
soc/intel: Split Jasper Lake SoC from Tiger Lake SoC code
Done. Commit message reworded.
https://review.coreboot.org/c/coreboot/+/39774/5//COMMIT_MSG@14 PS5, Line 14: This
lowercase?
Done
https://review.coreboot.org/c/coreboot/+/39774/5//COMMIT_MSG@15 PS5, Line 15: code(tgl
Please add as space before (.
Done
https://review.coreboot.org/c/coreboot/+/39774/4/src/soc/intel/jasperlake/in... File src/soc/intel/jasperlake/include/soc/romstage.h:
https://review.coreboot.org/c/coreboot/+/39774/4/src/soc/intel/jasperlake/in... PS4, Line 20: void mainboard_memory_init_params(FSPM_UPD *mupd);
need consistent spacing around '*' (ctx:WxV)
Done
https://review.coreboot.org/c/coreboot/+/39774/2/src/soc/intel/jasperlake/in... File src/soc/intel/jasperlake/include/soc/romstage.h:
https://review.coreboot.org/c/coreboot/+/39774/2/src/soc/intel/jasperlake/in... PS2, Line 20: void mainboard_memory_init_params(FSPM_UPD *mupd);
need consistent spacing around '*' (ctx:WxV)
Done
https://review.coreboot.org/c/coreboot/+/39774/6/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/pci_irqs.asl:
PS6:
This should have shown as a rename of pci_irqs_tgl.asl. Shows it when I commit the changes locally: […]
Done
https://review.coreboot.org/c/coreboot/+/39774/7/src/soc/intel/tigerlake/inc... File src/soc/intel/tigerlake/include/soc/pch.h:
https://review.coreboot.org/c/coreboot/+/39774/7/src/soc/intel/tigerlake/inc... PS7, Line 20: #define PCH_H 1 : #define PCH_LP 2 : #define PCH_UNKNOWN_SERIES 0xFF
Not required Furquan, removed it.
Done
-
Aamir Bohra (Code Review)