Attention is currently required from: Nico Huber, Matt DeVillier, Arthur Heymans, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55810 )
Change subject: broadwell boards: Do not set `ddr_refresh_2x` again
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/auron/variants/buddy/spd/spd.c:
https://review.coreboot.org/c/coreboot/+/55810/comment/79aa027b_80a317f4
PS9, Line 13: pei_data->ddr_refresh_2x = 1;
I looked through the (internal) board's development history. […]
Alright, thanks for checking.
On a related note, should 2x refresh mode be configurable for non-Google boards? I don't think so because other boards may also be susceptible to rowhammer attacks, but I'd like to know your thoughts.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55810
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I76478689b3aa27c369a0413d9fbde03674d5e528
Gerrit-Change-Number: 55810
Gerrit-PatchSet: 9
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 02 Nov 2021 09:15:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment