Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46275 )
Change subject: cpu/intel/common: rework AES-NI locking ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46275/3/src/cpu/intel/common/common... File src/cpu/intel/common/common_init.c:
https://review.coreboot.org/c/coreboot/+/46275/3/src/cpu/intel/common/common... PS3, Line 279: msr_unset_and_set(MSR_FEATURE_CONFIG, 0, AESNI_LOCK);
It says another write is not allowed, which could mean it won't have any effect, or it could generat […]
Tim, thank you very much. I'll add this
https://review.coreboot.org/c/coreboot/+/46275/4/src/cpu/intel/common/common... File src/cpu/intel/common/common_init.c:
https://review.coreboot.org/c/coreboot/+/46275/4/src/cpu/intel/common/common... PS4, Line 269: /* : * Lock AES-NI feature (MSR_FEATURE_CONFIG) to prevent unintended changes : * to the enablement state as suggested in Intel document 325384-070US. : */
This is redundant, it's copied verbatim from the header
So, where would you like to have this? here or in the header?
-
Michael Niewöhner (Code Review)