Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63658 )
Change subject: mb/google/guybrush: Remove EC_ENABLE_LID_SWITCH ......................................................................
mb/google/guybrush: Remove EC_ENABLE_LID_SWITCH
Remove EC_ENABLE_LID_SWITCH since this causes a duplicate SW_LID entries. The other SW_LID entry is generated by MKBP.
BUG=b:228907256 BRANCH=guybrush TEST=Lid open close triggers events on Nipperkin
Change-Id: I5c1cf7aeac8405bce7bfc77110eceaf3e5383fe7 Signed-off-by: Rob Barnes robbarnes@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/63658 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Robert Zieba robertzieba@google.com Reviewed-by: Jon Murphy jpmurphy@google.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved Jon Murphy: Looks good to me, but someone else must approve Robert Zieba: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h index 5695a8e..34e2edd 100644 --- a/src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h @@ -57,8 +57,7 @@ /* Enable MKBP for buttons and switches */ #define EC_ENABLE_MKBP_DEVICE
-/* Enable LID switch and provide wake pin for EC */ -#define EC_ENABLE_LID_SWITCH +/* Provide wake pin for EC */ #define EC_ENABLE_WAKE_PIN GEVENT_3 /* AGPIO 22 -> GPE 3 */
#define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */