Change in coreboot[master]: mb/clevo/cml-u: Configure IRQ as level triggered for HID over I2C - coreboot-gerrit

3 Jan 2021


      Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47984 )
Change subject: mb/clevo/cml-u: Configure IRQ as level triggered for HID over I2C
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47984/6//COMMIT_MSG 
Commit Message:
https://review.coreboot.org/c/coreboot/+/47984/6//COMMIT_MSG@15 
PS6, Line 15: PAD_CFG_GPI_APIC_HIGH. There is no need to invert the signal.
...
There is no need because the SoC supports active-low signals in the […]
agreed, as discussed; switched to _LOW
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/47984
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia232c0a11546aa6d17614f4cab07c255e58f2fed
Gerrit-Change-Number: 47984
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer:  Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 03 Jan 2021 16:49:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment