Attention is currently required from: Nicholas Chin.
Máté Kukri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81022?usp=email )
Change subject: mb/asrock: Add Z87E-ITX (Haswell) ......................................................................
Patch Set 2: Code-Review+1
(9 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81022/comment/f747fa17_8b9a2342 : PS2, Line 10: output to build against current main. I do not physically have this FIXMEs make sense with this context.
If you aren't able to check anything on this board anymore, please ack my comments.
Patchset:
PS2: LGTM.
File src/mainboard/asrock/z87e-itx/Kconfig:
PS2: I usually set CBFS_SIZE to cover the BIOS region in the flash descriptor.
File src/mainboard/asrock/z87e-itx/data.vbt:
PS2: How was this file obtained? Dump under Linux?
File src/mainboard/asrock/z87e-itx/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/81022/comment/2fb83ac7_0ab96271 : PS2, Line 11: -- FIXME: check this If you can, maybe try disabling the unused ones?
File src/mainboard/asrock/z87e-itx/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/81022/comment/b627072f_52ba6768 : PS2, Line 20: This board seems to have HDMI. Can you add the HDA verbs for HDMI audio?
File src/mainboard/asrock/z87e-itx/romstage.c:
https://review.coreboot.org/c/coreboot/+/81022/comment/0a5cd31c_7dd83929 : PS2, Line 12: /* FIXME: called after romstage_common, remove it if not used */ I guess try removing this?
https://review.coreboot.org/c/coreboot/+/81022/comment/38ebf795_9d140329 : PS2, Line 19: /* FIXME: check this */ Can you check which ones are needed with `i2cdetect`?
https://review.coreboot.org/c/coreboot/+/81022/comment/047f7171_1e89c1a1 : PS2, Line 27: /* FIXME: Length and Location are computed from IOBP values, may be inaccurate */ If all USB ports work, remove the FIXME?
-
Máté Kukri (Code Review)