Change in coreboot[master]: soc/amd/*/Makefile.inc: Do some cosmetics - coreboot-gerrit

8 Jul 2021


      Attention is currently required from: Jason Glenesk, Marshall Dawson, Arthur Heymans, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56117 )
Change subject: soc/amd/*/Makefile.inc: Do some cosmetics
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3: 
I'm not sure this makes things more understandable, but I don't have any outright objection to it.  It seems like using $< against a macro is maybe bad since the macro obfuscates what the prerequisites are.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/56117
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea2322ca1abd43900f3631b7965f07fed4235ca0
Gerrit-Change-Number: 56117
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Martin Roth martinroth@google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 08 Jul 2021 15:24:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment