Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47808 )
Change subject: sb/intel/lynxpoint: Replace hard-coded IDs with defines
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
Much better. Thanks!
https://review.coreboot.org/c/coreboot/+/47808/9/src/southbridge/intel/lynxp...
File src/southbridge/intel/lynxpoint/smbus.c:
https://review.coreboot.org/c/coreboot/+/47808/9/src/southbridge/intel/lynxp...
PS9, Line 83: 0x1c22,
: 0x1e22,
CB:47816 was merged, so a manual rebase is needed here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47808
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I910ab356dd8728c316018989bfb2689d4c67c2dc
Gerrit-Change-Number: 47808
Gerrit-PatchSet: 9
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 23 Nov 2020 18:01:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment