Subrata Banik has posted comments on this change. ( https://review.coreboot.org/18381 )
Change subject: soc/intel/common/block: Add cache as ram init and teardown code
......................................................................
Patch Set 40:
(1 comment)
https://review.coreboot.org/#/c/18381/40/src/soc/intel/skylake/Kconfig
File src/soc/intel/skylake/Kconfig:
PS40, Line 280: tear Down
But it wasn't completed. Why is it if we're going to critique comments we d
will fix in next Kconfig and ensure such things not getting missed in future.
--
To view, visit
https://review.coreboot.org/18381
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffd0c3e3ca81a3d283d5f1da115222a222e6b157
Gerrit-PatchSet: 40
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Barnali Sarkar
barnali.sarkar@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-Reviewer: dhaval v sharma
dhaval.v.sharma@intel.com
Gerrit-HasComments: Yes