Attention is currently required from: Furquan Shaikh, Jakub Czapiga, Julius Werner, Andrey Petrov, Patrick Rudolph.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52533 )
Change subject: commonlib/region: Turn addrspace_32bit into a more official API
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52533/comment/20a532ed_69351062
PS1, Line 15: 32 bits in 64-bit environments
fwiw, the naming was to convey minimum guarantees in what it represents. In 32-bit environment it can only be 32 bits of address space.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52533
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4c763b77f77d227768556a9528681d771a08dca
Gerrit-Change-Number: 52533
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 20 Apr 2021 13:55:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment