Hello Aaron Durbin, Zhuohao Lee, Daisuke Nojiri, build bot (Jenkins),
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/30857
to review the following change.
Change subject: Revert "mb/google/kalista: Disable EC-EFS" ......................................................................
Revert "mb/google/kalista: Disable EC-EFS"
This reverts commit 4e3cd744492c7a3d80bca55a35276efeada731e5.
Reason for revert: Daisuke says "We'll keep EFS on Kalista/Karma enabled"
Change-Id: I2f11ffc9dd7eb05a2560261bbf472e8488c274d9 --- M src/mainboard/google/fizz/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/30857/1
diff --git a/src/mainboard/google/fizz/Kconfig b/src/mainboard/google/fizz/Kconfig index e1fc38d..4d08eda 100644 --- a/src/mainboard/google/fizz/Kconfig +++ b/src/mainboard/google/fizz/Kconfig @@ -37,7 +37,7 @@
config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES - select VBOOT_EC_EFS if BOARD_GOOGLE_FIZZ + select VBOOT_EC_EFS select VBOOT_PHYSICAL_REC_SWITCH select HAS_RECOVERY_MRC_CACHE select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN
Daisuke Nojiri has uploaded a new patch set (#2) to the change originally created by Patrick Georgi. ( https://review.coreboot.org/c/coreboot/+/30857 )
Change subject: Revert "mb/google/kalista: Disable EC-EFS" ......................................................................
Revert "mb/google/kalista: Disable EC-EFS"
This reverts commit 4e3cd744492c7a3d80bca55a35276efeada731e5.
Reason for revert: Daisuke says "We'll keep EFS on Kalista/Karma enabled"
Signed-off-by: Daisuke Nojiri dnojiri@chromium.org Change-Id: I2f11ffc9dd7eb05a2560261bbf472e8488c274d9 --- M src/mainboard/google/fizz/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/30857/2
Daisuke Nojiri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30857 )
Change subject: Revert "mb/google/kalista: Disable EC-EFS" ......................................................................
Patch Set 2: Code-Review+2
The change looks good.
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30857 )
Change subject: Revert "mb/google/kalista: Disable EC-EFS" ......................................................................
Revert "mb/google/kalista: Disable EC-EFS"
This reverts commit 4e3cd744492c7a3d80bca55a35276efeada731e5.
Reason for revert: Daisuke says "We'll keep EFS on Kalista/Karma enabled"
Signed-off-by: Daisuke Nojiri dnojiri@chromium.org Change-Id: I2f11ffc9dd7eb05a2560261bbf472e8488c274d9 Reviewed-on: https://review.coreboot.org/c/30857 Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/fizz/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Daisuke Nojiri: Looks good to me, approved
diff --git a/src/mainboard/google/fizz/Kconfig b/src/mainboard/google/fizz/Kconfig index 1748d89..6f05c24 100644 --- a/src/mainboard/google/fizz/Kconfig +++ b/src/mainboard/google/fizz/Kconfig @@ -39,7 +39,7 @@
config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES - select VBOOT_EC_EFS if BOARD_GOOGLE_FIZZ + select VBOOT_EC_EFS select VBOOT_PHYSICAL_REC_SWITCH select HAS_RECOVERY_MRC_CACHE select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN
-
Daisuke Nojiri (Code Review) -
Patrick Georgi (Code Review)