build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35321 )
Change subject: soc/fsp_broadwell_de: Add devhide functionality ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35321/3/src/soc/intel/fsp_broadwell... File src/soc/intel/fsp_broadwell_de/southcluster.c:
https://review.coreboot.org/c/coreboot/+/35321/3/src/soc/intel/fsp_broadwell... PS3, Line 254: if (dev->enabled) suspect code indent for conditional statements (8, 12)
https://review.coreboot.org/c/coreboot/+/35321/3/src/soc/intel/fsp_broadwell... PS3, Line 255: return; Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/35321/3/src/soc/intel/fsp_broadwell... PS3, Line 266: printk(BIOS_DEBUG, "%s: Disabling IOU bridge %02x.%01x\n", dev_path(dev), slot, func); line over 96 characters
https://review.coreboot.org/c/coreboot/+/35321/3/src/soc/intel/fsp_broadwell... PS3, Line 270: printk(BIOS_DEBUG, "%s: Disabling device: %02x.%01x\n", dev_path(dev), slot, func); line over 96 characters
-
build bot (Jenkins) (Code Review)