Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79047?usp=email )
(
4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: acpi/acpigen: drop len assert in acpigen_pop_len ......................................................................
acpi/acpigen: drop len assert in acpigen_pop_len
This is already handled as a separate case in the code below, so there's no need for this assert any more.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I7511ec5683a924dc289faa2b9fabd0e8714d291e Reviewed-on: https://review.coreboot.org/c/coreboot/+/79047 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com Reviewed-by: Nico Huber nico.h@gmx.de --- M src/acpi/acpigen.c 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved Nico Huber: Looks good to me, but someone else must approve
diff --git a/src/acpi/acpigen.c b/src/acpi/acpigen.c index 7479dce..fe36113 100644 --- a/src/acpi/acpigen.c +++ b/src/acpi/acpigen.c @@ -5,7 +5,6 @@
/* If you need to change this, change acpigen_pop_len too */ #define ACPIGEN_RSVD_PKGLEN_BYTES 3 -#define ACPIGEN_MAXLEN 0xfffff
#include <lib.h> #include <string.h> @@ -38,7 +37,6 @@ ASSERT(ltop > 0) char *p = len_stack[--ltop]; len = gencurrent - p; - ASSERT(len <= ACPIGEN_MAXLEN) const size_t payload_len = len - ACPIGEN_RSVD_PKGLEN_BYTES;
if (len <= 0x3f + 2) {