HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36046 )
Change subject: src/superio: Remove unused 'include <arch/io.h>' ......................................................................
src/superio: Remove unused 'include <arch/io.h>'
Change-Id: Ia08e27da51f1f523232379960dc21c1ba4849932 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/aspeed/ast2400/superio.c M src/superio/aspeed/common/aspeed.h M src/superio/fintek/common/fan_control.h M src/superio/ite/common/env_ctrl.c 4 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/36046/1
diff --git a/src/superio/aspeed/ast2400/superio.c b/src/superio/aspeed/ast2400/superio.c index 54f3f34..bd59fd6 100644 --- a/src/superio/aspeed/ast2400/superio.c +++ b/src/superio/aspeed/ast2400/superio.c @@ -15,7 +15,6 @@ * GNU General Public License for more details. */
-#include <arch/io.h> #include <device/device.h> #include <device/pnp.h> #include <superio/conf_mode.h> diff --git a/src/superio/aspeed/common/aspeed.h b/src/superio/aspeed/common/aspeed.h index d3774ea..8c54b0c 100644 --- a/src/superio/aspeed/common/aspeed.h +++ b/src/superio/aspeed/common/aspeed.h @@ -18,7 +18,6 @@ #ifndef SUPERIO_ASPEED_COMMON_ROMSTAGE_H #define SUPERIO_ASPEED_COMMON_ROMSTAGE_H
-#include <arch/io.h> #include <device/pnp_type.h> #include <stdint.h>
diff --git a/src/superio/fintek/common/fan_control.h b/src/superio/fintek/common/fan_control.h index fbe784b..c316778 100644 --- a/src/superio/fintek/common/fan_control.h +++ b/src/superio/fintek/common/fan_control.h @@ -18,7 +18,6 @@ #define SUPERIO_FINTEK_FAN_CONTROL_H
#include <stdint.h> -#include <arch/io.h>
typedef enum { IGNORE_SENSOR = 0, diff --git a/src/superio/ite/common/env_ctrl.c b/src/superio/ite/common/env_ctrl.c index 2f2942b..bee0a50 100644 --- a/src/superio/ite/common/env_ctrl.c +++ b/src/superio/ite/common/env_ctrl.c @@ -18,7 +18,6 @@ */
#include <stdlib.h> -#include <arch/io.h> #include <console/console.h> #include <delay.h> #include <superio/hwm5_conf.h>
Hello Felix Held, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36046
to look at the new patch set (#2).
Change subject: src/superio: Remove unused 'include <arch/io.h>' ......................................................................
src/superio: Remove unused 'include <arch/io.h>'
Change-Id: Ia08e27da51f1f523232379960dc21c1ba4849932 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/aspeed/ast2400/superio.c M src/superio/aspeed/common/aspeed.h M src/superio/fintek/common/fan_control.h M src/superio/fintek/f81803a/fan_control.c M src/superio/ite/common/env_ctrl.c 5 files changed, 1 insertion(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/36046/2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36046 )
Change subject: src/superio: Remove unused 'include <arch/io.h>' ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36046 )
Change subject: src/superio: Remove unused 'include <arch/io.h>' ......................................................................
src/superio: Remove unused 'include <arch/io.h>'
Change-Id: Ia08e27da51f1f523232379960dc21c1ba4849932 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/36046 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/superio/aspeed/ast2400/superio.c M src/superio/aspeed/common/aspeed.h M src/superio/fintek/common/fan_control.h M src/superio/fintek/f81803a/fan_control.c M src/superio/ite/common/env_ctrl.c 5 files changed, 1 insertion(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/superio/aspeed/ast2400/superio.c b/src/superio/aspeed/ast2400/superio.c index 54f3f34..bd59fd6 100644 --- a/src/superio/aspeed/ast2400/superio.c +++ b/src/superio/aspeed/ast2400/superio.c @@ -15,7 +15,6 @@ * GNU General Public License for more details. */
-#include <arch/io.h> #include <device/device.h> #include <device/pnp.h> #include <superio/conf_mode.h> diff --git a/src/superio/aspeed/common/aspeed.h b/src/superio/aspeed/common/aspeed.h index d3774ea..8c54b0c 100644 --- a/src/superio/aspeed/common/aspeed.h +++ b/src/superio/aspeed/common/aspeed.h @@ -18,7 +18,6 @@ #ifndef SUPERIO_ASPEED_COMMON_ROMSTAGE_H #define SUPERIO_ASPEED_COMMON_ROMSTAGE_H
-#include <arch/io.h> #include <device/pnp_type.h> #include <stdint.h>
diff --git a/src/superio/fintek/common/fan_control.h b/src/superio/fintek/common/fan_control.h index fbe784b..c316778 100644 --- a/src/superio/fintek/common/fan_control.h +++ b/src/superio/fintek/common/fan_control.h @@ -18,7 +18,6 @@ #define SUPERIO_FINTEK_FAN_CONTROL_H
#include <stdint.h> -#include <arch/io.h>
typedef enum { IGNORE_SENSOR = 0, diff --git a/src/superio/fintek/f81803a/fan_control.c b/src/superio/fintek/f81803a/fan_control.c index 17ae9c6..41fd0d3 100644 --- a/src/superio/fintek/f81803a/fan_control.c +++ b/src/superio/fintek/f81803a/fan_control.c @@ -14,6 +14,7 @@ * GNU General Public License for more details. */
+#include <arch/io.h> #include <console/console.h> #include "../common/fan_control.h" #include "f81803a_hwm.h" diff --git a/src/superio/ite/common/env_ctrl.c b/src/superio/ite/common/env_ctrl.c index 2f2942b..bee0a50 100644 --- a/src/superio/ite/common/env_ctrl.c +++ b/src/superio/ite/common/env_ctrl.c @@ -18,7 +18,6 @@ */
#include <stdlib.h> -#include <arch/io.h> #include <console/console.h> #include <delay.h> #include <superio/hwm5_conf.h>
-
Felix Held (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)