Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37441 )
Change subject: mb/supermicro/x11-lga1151v2-series: Add support for X11SCH-F ......................................................................
Patch Set 65: Code-Review+1
(7 comments)
https://review.coreboot.org/c/coreboot/+/37441/65/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151v2-series/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37441/65/src/mainboard/supermicro/x... PS65, Line 10: device pci 01.0 on end Missing comment.
https://review.coreboot.org/c/coreboot/+/37441/65/src/mainboard/supermicro/x... PS65, Line 16: device pci 14.2 on end Missing comment.
https://review.coreboot.org/c/coreboot/+/37441/65/src/mainboard/supermicro/x... PS65, Line 19: device pci 16.0 on end # Management Engine Interface Add interface number
https://review.coreboot.org/c/coreboot/+/37441/65/src/mainboard/supermicro/x... PS65, Line 20: device pci 16.1 on end # Management Engine Interface Same
https://review.coreboot.org/c/coreboot/+/37441/65/src/mainboard/supermicro/x... PS65, Line 21: device pci 16.4 on end # Management Engine Interface Same
https://review.coreboot.org/c/coreboot/+/37441/65/src/mainboard/supermicro/x... PS65, Line 23: device pci 1c.1 on Missing comment.
https://review.coreboot.org/c/coreboot/+/37441/65/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151v2-series/variants/x11sch-f/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37441/65/src/mainboard/supermicro/x... PS65, Line 114: device domain 0 on Please add root port numbers.