Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Tim Wawrzynczak.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56264 )
Change subject: drivers/usb/acpi: Fix usb_acpi_get_pld
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/usb/acpi/usb_acpi.c:
https://review.coreboot.org/c/coreboot/+/56264/comment/ead6b528_ca33c376
PS2, Line 136: memcpy(pld, &config->custom_pld, sizeof(*pld));
Just don't use memcpy, it's not needed: CB:56265
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56264
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I424ae185f544c13c0638ff57c097d784265f2848
Gerrit-Change-Number: 56264
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 13 Jul 2021 17:11:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment