Attention is currently required from: Ashish Kumar Mishra, Harsha B R, Rizwan Qureshi, Krishna P Bhat D, Ronak Kanabar, Usha P.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69741 )
Change subject: mb/intel/mtlrvp: Add romstage and configure LP5 memory parts
......................................................................
Patch Set 10:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69741/comment/39d17f31_dea003f0
PS10, Line 13: FW_NAME=mtlrvp_p emerge-rex coreboot chromeos-bootimage
Note: building the MTLRVP can't be a test statement, the purpose of the test is to ensure the code that you have added is actually meant to fix something or enable some feature. Adding a test statement like this would mean nothing IMO.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69741
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15b352eb246aed23da273e56490c7094eae9d176
Gerrit-Change-Number: 69741
Gerrit-PatchSet: 10
Gerrit-Owner: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-CC: Harsha B R
harsha.b.r@intel.com
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Attention: Harsha B R
harsha.b.r@intel.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Comment-Date: Tue, 29 Nov 2022 08:28:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment