Attention is currently required from: Arthur Heymans, Gaggery Tsai, Subrata Banik.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77255?usp=email )
Change subject: src/soc/intel/common: Add ACPI BDAT support
......................................................................
Patch Set 10:
(4 comments)
File src/soc/intel/common/block/acpi/acpi_bdat.c:
https://review.coreboot.org/c/coreboot/+/77255/comment/176c83d3_10406fd9 :
PS10, Line 24: 8
Use Macros instead of magic numbers.
https://review.coreboot.org/c/coreboot/+/77255/comment/46b5c5b4_5595eb4c :
PS10, Line 26: i != 7
Magic Number
https://review.coreboot.org/c/coreboot/+/77255/comment/b5bdc410_49ff4b7e :
PS10, Line 40: 8
Magic Number
https://review.coreboot.org/c/coreboot/+/77255/comment/426bbd51_c2b8a135 :
PS10, Line 41: 0x8000
Magic Number
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77255?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5eb57f65ef5f24458f09587b7c7694156f2ed1ce
Gerrit-Change-Number: 77255
Gerrit-PatchSet: 10
Gerrit-Owner: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 18 Sep 2023 16:00:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment