Attention is currently required from: Jon Murphy, Karthik Ramasubramanian, Martin L Roth.
Raul Rangel has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/86148?usp=email )
Change subject: util/crossgcc: Add missing printf variable
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
File util/crossgcc/buildgcc:
https://review.coreboot.org/c/coreboot/+/86148/comment/704e68bc_76e379a4?usp... :
PS1, Line 861: printf
Odd choice of using printf over string substitution.
https://review.coreboot.org/c/coreboot/+/86148/comment/a26dc9bb_09ca5687?usp... :
PS1, Line 861: ${LIBSTDCXX_INCLUDE_PATH}
Quotes
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86148?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I195718e43ea842970f5fa986315c9e9f11395362
Gerrit-Change-Number: 86148
Gerrit-PatchSet: 1
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 24 Jan 2025 21:52:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes