Attention is currently required from: Kevin Chiu, Furquan Shaikh, Bhanu Prakash Maiya, Eric Peers, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50282 )
Change subject: mb/google/zork: update USB 3 controller phy Parameter for dirinboz
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/zork/variants/dirinboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/50282/comment/1e388e33_64a137b5
PS2, Line 66: register "usb3_phy_tune_params[0]"
Do we need to add the default params for all 4 ports? Right now, they'd get set to 0.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50282
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42a94e03fb6f8230d4356d16b8e0d2164bc61e3f
Gerrit-Change-Number: 50282
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Attention: Eric Peers
epeers@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 04 Feb 2021 18:07:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment