Attention is currently required from: Alexander Couzens. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60723 )
Change subject: ec/lenovo/h8/acpi: Replace And() with ASL 2.0 syntax ......................................................................
ec/lenovo/h8/acpi: Replace And() with ASL 2.0 syntax
Change-Id: Id600bcb3fad35455adffe11a8105ad2590e83feb Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/ec/lenovo/h8/acpi/thinkpad.asl 1 file changed, 9 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/60723/1
diff --git a/src/ec/lenovo/h8/acpi/thinkpad.asl b/src/ec/lenovo/h8/acpi/thinkpad.asl index 8d412d2..ee813c9 100644 --- a/src/ec/lenovo/h8/acpi/thinkpad.asl +++ b/src/ec/lenovo/h8/acpi/thinkpad.asl @@ -52,7 +52,7 @@ /* Report event */ Method (RHK, 1, NotSerialized) { ShiftLeft (One, Arg0 - 1, Local0) - If (And (EMSK, Local0)) { + If (EMSK & Local0) { Store (Arg0, BTN) Notify (HKEY, 0x80) } @@ -61,7 +61,7 @@ /* Report tablet */ Method (RTAB, 1, NotSerialized) { ShiftLeft (One, Arg0 - 1, Local0) - If (And (ETAB, Local0)) { + If (ETAB & Local0) { Store (Arg0, BTAB) Notify (HKEY, 0x80) } @@ -91,7 +91,7 @@ } Else { - And (DHKN, Not (Local0), DHKN) + DHKN = DHKN & Not (Local0) } If (EN) { @@ -184,9 +184,9 @@ Store (One, HAST)
If (HBDC) { - ShiftRight (And(Arg0, 2), 1, Local0) + ShiftRight (Arg0 & 2, 1, Local0) Store (Local0, _SB.PCI0.LPCB.EC.BTEB) - ShiftRight (And(Arg0, 4), 2, Local0) + ShiftRight (Arg0 & 4, 2, Local0) Store (Local0, WBDC) } } @@ -226,9 +226,9 @@ Store (One, HAST)
If (HWAN) { - ShiftRight (And(Arg0, 2), 1, Local0) + ShiftRight (Arg0 & 2, 1, Local0) Store (Local0, _SB.PCI0.LPCB.EC.WWEB) - ShiftRight (And(Arg0, 4), 2, WWAN) + ShiftRight (Arg0 & 4, 2, WWAN) } }
@@ -258,7 +258,7 @@ { If (HKBL) { /* FIXME: Support 2bit brightness control */ - Store (And(Arg0, 1), _SB.PCI0.LPCB.EC.WWEB) + Store (Arg0 & 1, _SB.PCI0.LPCB.EC.WWEB) } }
@@ -288,7 +288,7 @@ Method (SUWB, 1) { If (HUWB) { - ShiftRight (And(Arg0, 2), 1, Local0) + ShiftRight (Arg0 & 2, 1, Local0) Store (Local0, _SB.PCI0.LPCB.EC.UWBE) } }