Change in coreboot[master]: soc/intel/xeon_sp/cpx: Set SLEEP_BUTTON flag in ACPI FADT

[Morgan Jang (Code Review)]

Morgan Jang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46650 )

Change subject: soc/intel/xeon_sp/cpx: Set SLEEP_BUTTON flag in ACPI FADT
......................................................................

soc/intel/xeon_sp/cpx: Set SLEEP_BUTTON flag in ACPI FADT

Set SLEEP_BUTTON flag in ACPI FADT to indicate that no sleep button on
Copperlake platform.

Change-Id: I268c178dfc094299ea6ec239aa1a7c82ccdb0410
Signed-off-by: Morgan Jang 
---
M src/soc/intel/xeon_sp/cpx/acpi.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/46650/1

diff --git a/src/soc/intel/xeon_sp/cpx/acpi.c b/src/soc/intel/xeon_sp/cpx/acpi.c
index a1ebc4a..a1af52f 100644
--- a/src/soc/intel/xeon_sp/cpx/acpi.c
+++ b/src/soc/intel/xeon_sp/cpx/acpi.c
@@ -152,7 +152,7 @@
    fadt->day_alrm = 0xd;

fadt->flags |= ACPI_FADT_WBINVD | ACPI_FADT_C1_SUPPORTED | ACPI_FADT_C2_MP_SUPPORTED |
-			ACPI_FADT_PLATFORM_CLOCK;
+			ACPI_FADT_PLATFORM_CLOCK | ACPI_FADT_SLEEP_BUTTON;

fadt->x_pm1a_evt_blk.space_id = ACPI_ADDRESS_SPACE_IO;
    fadt->x_pm1a_evt_blk.bit_width = fadt->pm1_evt_len * 8;

[Jonathan Zhang (Code Review)]

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46650 )

Change subject: soc/intel/xeon_sp/cpx: Set SLEEP_BUTTON flag in ACPI FADT
......................................................................

Patch Set 1: Code-Review+1

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46650 )

Change subject: soc/intel/xeon_sp/cpx: Set SLEEP_BUTTON flag in ACPI FADT
......................................................................

Patch Set 1: Code-Review+2

(2 comments)

ACPI spec agrees.

https://review.coreboot.org/c/coreboot/+/46650/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/46650/1//COMMIT_MSG@9 
PS1, Line 9: no sleep button
nit: no sleep button *is present* on

https://review.coreboot.org/c/coreboot/+/46650/1//COMMIT_MSG@10 
PS1, Line 10: Copperlake
nit: Co*o*perlake

[Morgan Jang (Code Review)]

Hello build bot (Jenkins), Marc Jones, Jonathan Zhang, Johnny Lin, Paul Menzel, Jingle Hsu, Angel Pons, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46650

to look at the new patch set (#2).

Change subject: soc/intel/xeon_sp/cpx: Set SLEEP_BUTTON flag in ACPI FADT
......................................................................

soc/intel/xeon_sp/cpx: Set SLEEP_BUTTON flag in ACPI FADT

Set SLEEP_BUTTON flag in ACPI FADT to indicate that no sleep button
is present on Cooperlake platform.

Change-Id: I268c178dfc094299ea6ec239aa1a7c82ccdb0410
Signed-off-by: Morgan Jang 
---
M src/soc/intel/xeon_sp/cpx/acpi.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/46650/2

[Morgan Jang (Code Review)]

Morgan Jang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46650 )

Change subject: soc/intel/xeon_sp/cpx: Set SLEEP_BUTTON flag in ACPI FADT
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46650/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/46650/1//COMMIT_MSG@9 
PS1, Line 9: no sleep button
> nit: no sleep button *is present* on

Done

https://review.coreboot.org/c/coreboot/+/46650/1//COMMIT_MSG@10 
PS1, Line 10: Copperlake
> nit: Co*o*perlake

Done

[Johnny Lin (Code Review)]

Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46650 )

Change subject: soc/intel/xeon_sp/cpx: Set SLEEP_BUTTON flag in ACPI FADT
......................................................................

Patch Set 2:

The file will be moved to xeon_sp/acpi.c in CB:46600, FYI.

[Morgan Jang (Code Review)]

Morgan Jang has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46650 )

Change subject: soc/intel/xeon_sp/cpx: Set SLEEP_BUTTON flag in ACPI FADT
......................................................................

Abandoned

The upstream code has set this flag.