Hello HAOUAS Elyes,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/37827
to review the following change.
Change subject: src/include: Remove unused <stdlib.h> ......................................................................
src/include: Remove unused <stdlib.h>
Change-Id: I9e5d18739e7c5b5c742a905ac482529c7e0866df Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/bootstate.h M src/include/device/i2c_bus.h M src/include/string.h 3 files changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/37827/1
diff --git a/src/include/bootstate.h b/src/include/bootstate.h index 26038c6..c53884e 100644 --- a/src/include/bootstate.h +++ b/src/include/bootstate.h @@ -16,7 +16,6 @@ #define BOOTSTATE_H
#include <string.h> -#include <stdlib.h> #include <stddef.h> #include <stdint.h> /* Only declare main() when in ramstage. */ diff --git a/src/include/device/i2c_bus.h b/src/include/device/i2c_bus.h index 5302d20..81eae11 100644 --- a/src/include/device/i2c_bus.h +++ b/src/include/device/i2c_bus.h @@ -14,7 +14,6 @@ #ifndef _DEVICE_I2C_BUS_H_ #define _DEVICE_I2C_BUS_H_
-#include <stdlib.h> #include <stdint.h> #include <device/i2c.h> #include <device/device.h> diff --git a/src/include/string.h b/src/include/string.h index bcfc111..b55ca5f 100644 --- a/src/include/string.h +++ b/src/include/string.h @@ -2,7 +2,6 @@ #define STRING_H
#include <stddef.h> -#include <stdlib.h>
#include <console/vtxprintf.h>
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37827 )
Change subject: src/include: Remove unused <stdlib.h> ......................................................................
Patch Set 3: Code-Review+1
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37827 )
Change subject: src/include: Remove unused <stdlib.h> ......................................................................
Patch Set 6:
This is to replace CB:32023 unless someone wants to override all those (now unrelated) unresolved comments there.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37827 )
Change subject: src/include: Remove unused <stdlib.h> ......................................................................
Patch Set 6:
Patch Set 6:
This is to replace CB:32023 unless someone wants to override all those (now unrelated) unresolved comments there.
I've rebased the changes previously depending on CB:32023, on top of this CB:37827 change.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37827 )
Change subject: src/include: Remove unused <stdlib.h> ......................................................................
Patch Set 6: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37827 )
Change subject: src/include: Remove unused <stdlib.h> ......................................................................
Patch Set 6: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37827 )
Change subject: src/include: Remove unused <stdlib.h> ......................................................................
src/include: Remove unused <stdlib.h>
Change-Id: I9e5d18739e7c5b5c742a905ac482529c7e0866df Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/37827 Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Frans Hendriks fhendriks@eltan.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/include/bootstate.h M src/include/device/i2c_bus.h M src/include/string.h 3 files changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Frans Hendriks: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/include/bootstate.h b/src/include/bootstate.h index 26038c6..c53884e 100644 --- a/src/include/bootstate.h +++ b/src/include/bootstate.h @@ -16,7 +16,6 @@ #define BOOTSTATE_H
#include <string.h> -#include <stdlib.h> #include <stddef.h> #include <stdint.h> /* Only declare main() when in ramstage. */ diff --git a/src/include/device/i2c_bus.h b/src/include/device/i2c_bus.h index 5302d20..81eae11 100644 --- a/src/include/device/i2c_bus.h +++ b/src/include/device/i2c_bus.h @@ -14,7 +14,6 @@ #ifndef _DEVICE_I2C_BUS_H_ #define _DEVICE_I2C_BUS_H_
-#include <stdlib.h> #include <stdint.h> #include <device/i2c.h> #include <device/device.h> diff --git a/src/include/string.h b/src/include/string.h index bcfc111..b55ca5f 100644 --- a/src/include/string.h +++ b/src/include/string.h @@ -2,7 +2,6 @@ #define STRING_H
#include <stddef.h> -#include <stdlib.h>
#include <console/vtxprintf.h>