Attention is currently required from: mturney mturney, Julius Werner, Sudheer Amrabadi.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72634 )
Change subject: soc/qualcomm/common: Add sdhci_msm_init function
......................................................................
Patch Set 3:
(2 comments)
File src/soc/qualcomm/common/include/soc/sdhci_msm.h:
https://review.coreboot.org/c/coreboot/+/72634/comment/051ccc2e_f7fe6e0d
PS2, Line 54: #define CMDIN_RCLK_EN (1 << 1)
I don't think we need all of these definitions?
Yeah, you're right. I'll clean out the ones that we're not using.
File src/soc/qualcomm/common/storage/sdhci_msm.c:
https://review.coreboot.org/c/coreboot/+/72634/comment/ed8f6905_29c50a07
PS2, Line 64: if (host == NULL)
I think this can be simplified to a one-liner.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72634
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f4fd1360af1082b335f9cc3046871ce9963b5d0
Gerrit-Change-Number: 72634
Gerrit-PatchSet: 3
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-Comment-Date: Thu, 02 Feb 2023 16:38:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment