Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37185 )
Change subject: nb/intel/sandybridge: Fix mrc.bin path ......................................................................
nb/intel/sandybridge: Fix mrc.bin path
The mrc.bin uses a lot of stack.
Change-Id: Ic422980ca1a0549b6937e30a433ce52e0d7a595c Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/sandybridge/Kconfig 1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/37185/1
diff --git a/src/northbridge/intel/sandybridge/Kconfig b/src/northbridge/intel/sandybridge/Kconfig index 0502b50..7a27d09 100644 --- a/src/northbridge/intel/sandybridge/Kconfig +++ b/src/northbridge/intel/sandybridge/Kconfig @@ -74,7 +74,10 @@
config DCACHE_BSP_STACK_SIZE hex - default 0x2800 + default 0x10000 + help + The amount of BSP stack anticipated in bootblock and + other stages.
if USE_NATIVE_RAMINIT
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37185 )
Change subject: nb/intel/sandybridge: Fix mrc.bin path ......................................................................
Patch Set 1: Code-Review+2
fixes MRC boot on stout, stumpy, link (that I've tested)
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37185 )
Change subject: nb/intel/sandybridge: Fix mrc.bin path ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37185/1/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/Kconfig:
https://review.coreboot.org/c/coreboot/+/37185/1/src/northbridge/intel/sandy... PS1, Line 79: The amount of BSP stack anticipated in bootblock and Is there a reason to not place this unde if !USE_NATIVE_RAMINIT ?
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37185 )
Change subject: nb/intel/sandybridge: Fix mrc.bin path ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37185/1/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/Kconfig:
https://review.coreboot.org/c/coreboot/+/37185/1/src/northbridge/intel/sandy... PS1, Line 79: The amount of BSP stack anticipated in bootblock and
Is there a reason to not place this unde if !USE_NATIVE_RAMINIT ?
While not there yet, I'd like the CAR set up in bootblock to be compatible with either bootpaths in romstage. Most of of the 128K CAR ends up unused on the native codepath so this does not really matter.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37185 )
Change subject: nb/intel/sandybridge: Fix mrc.bin path ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37185/1/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/Kconfig:
https://review.coreboot.org/c/coreboot/+/37185/1/src/northbridge/intel/sandy... PS1, Line 79: The amount of BSP stack anticipated in bootblock and
Is there a reason to not place this unde if !USE_NATIVE_RAMINIT ? […]
Good point, please mention it in the commit message.
Hello Patrick Rudolph, Matt DeVillier, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37185
to look at the new patch set (#2).
Change subject: nb/intel/sandybridge: Fix mrc.bin path ......................................................................
nb/intel/sandybridge: Fix mrc.bin path
The mrc.bin uses a lot of stack. The BSP stack size is kept the same for both romstage bootpaths, mrc.bin and native, in order for the CAR symbol/setups to be compatible.
Change-Id: Ic422980ca1a0549b6937e30a433ce52e0d7a595c Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/sandybridge/Kconfig 1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/37185/2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37185 )
Change subject: nb/intel/sandybridge: Fix mrc.bin path ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37185/1/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/Kconfig:
https://review.coreboot.org/c/coreboot/+/37185/1/src/northbridge/intel/sandy... PS1, Line 79: The amount of BSP stack anticipated in bootblock and
Good point, please mention it in the commit message.
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37185 )
Change subject: nb/intel/sandybridge: Fix mrc.bin path ......................................................................
nb/intel/sandybridge: Fix mrc.bin path
The mrc.bin uses a lot of stack. The BSP stack size is kept the same for both romstage bootpaths, mrc.bin and native, in order for the CAR symbol/setups to be compatible.
Change-Id: Ic422980ca1a0549b6937e30a433ce52e0d7a595c Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/37185 Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Matt DeVillier matt.devillier@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/northbridge/intel/sandybridge/Kconfig 1 file changed, 4 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Matt DeVillier: Looks good to me, approved
diff --git a/src/northbridge/intel/sandybridge/Kconfig b/src/northbridge/intel/sandybridge/Kconfig index 0502b50..7a27d09 100644 --- a/src/northbridge/intel/sandybridge/Kconfig +++ b/src/northbridge/intel/sandybridge/Kconfig @@ -74,7 +74,10 @@
config DCACHE_BSP_STACK_SIZE hex - default 0x2800 + default 0x10000 + help + The amount of BSP stack anticipated in bootblock and + other stages.
if USE_NATIVE_RAMINIT
-
Arthur Heymans (Code Review) -
Kyösti Mälkki (Code Review)
-
Matt DeVillier (Code Review)
-
Patrick Georgi (Code Review)