Change in coreboot[master]: Doc/mb/index.md: Fix mainboard vendor order

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Angel Pons (Code Review)

3 Apr 2020 3 Apr '20

1:22 p.m.

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40118 )

Change subject: Doc/mb/index.md: Fix mainboard vendor order ......................................................................

Doc/mb/index.md: Fix mainboard vendor order

Oops, Libretrend "stole" all the Thinkpads from Lenovo. Correct that.

Change-Id: I15f189dedab98fdbea8c26ceb8ac84486df2519b Signed-off-by: Angel Pons th3fanbus@gmail.com --- M Documentation/mainboard/index.md 1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/40118/1

diff --git a/Documentation/mainboard/index.md b/Documentation/mainboard/index.md index 99e5dd0..7637f7b 100644 --- a/Documentation/mainboard/index.md +++ b/Documentation/mainboard/index.md @@ -75,10 +75,6 @@ - [T4xx common](lenovo/t4xx_series.md) - [X2xx common](lenovo/x2xx_series.md)

-## Libretrend - -- [LT1000](libretrend/lt1000.md) - ### Arrandale series

- [T410](lenovo/t410.md) @@ -107,6 +103,10 @@

- [T440p](lenovo/t440p.md)

+## Libretrend + +- [LT1000](libretrend/lt1000.md) + ## MSI

- [MS-7707](msi/ms7707/ms7707.md)

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

Michael Niewöhner (Code Review)

3 Apr 3 Apr

1:23 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40118 )

Change subject: Doc/mb/index.md: Fix mainboard vendor order ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40118 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15f189dedab98fdbea8c26ceb8ac84486df2519b Gerrit-Change-Number: 40118 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Fri, 03 Apr 2020 11:23:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

1:26 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40118 )

Change subject: Doc/mb/index.md: Fix mainboard vendor order ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40118 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15f189dedab98fdbea8c26ceb8ac84486df2519b Gerrit-Change-Number: 40118 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 03 Apr 2020 11:26:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

1:28 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40118 )

Change subject: Doc/mb/index.md: Fix mainboard vendor order ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/40118 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15f189dedab98fdbea8c26ceb8ac84486df2519b Gerrit-Change-Number: 40118 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 03 Apr 2020 11:28:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Michał Żygowski (Code Review)

3:43 p.m.

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40118 )

Change subject: Doc/mb/index.md: Fix mainboard vendor order ......................................................................

Patch Set 1: Code-Review+2

My bad... Overlooked the `###` header...

-- To view, visit https://review.coreboot.org/c/coreboot/+/40118 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15f189dedab98fdbea8c26ceb8ac84486df2519b Gerrit-Change-Number: 40118 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 03 Apr 2020 13:43:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Michał Żygowski (Code Review)

3:43 p.m.

Michał Żygowski has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40118 )

Change subject: Doc/mb/index.md: Fix mainboard vendor order ......................................................................

Doc/mb/index.md: Fix mainboard vendor order

Oops, Libretrend "stole" all the Thinkpads from Lenovo. Correct that.

Change-Id: I15f189dedab98fdbea8c26ceb8ac84486df2519b Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40118 Reviewed-by: Michael Niewöhner Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Michał Żygowski michal.zygowski@3mdeb.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Documentation/mainboard/index.md 1 file changed, 4 insertions(+), 4 deletions(-)

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Michał Żygowski: Looks good to me, approved Michael Niewöhner: Looks good to me, approved

-## Libretrend - -- [LT1000](libretrend/lt1000.md) - ### Arrandale series

- [T410](lenovo/t410.md) @@ -107,6 +103,10 @@

- [T440p](lenovo/t440p.md)

+## Libretrend + +- [LT1000](libretrend/lt1000.md) + ## MSI

- [MS-7707](msi/ms7707/ms7707.md)

-- To view, visit https://review.coreboot.org/c/coreboot/+/40118 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15f189dedab98fdbea8c26ceb8ac84486df2519b Gerrit-Change-Number: 40118 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

9elements QA (Code Review)

4:26 p.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40118 )

Change subject: Doc/mb/index.md: Fix mainboard vendor order ......................................................................

Patch Set 2:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2021 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2020 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2019

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/40118 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15f189dedab98fdbea8c26ceb8ac84486df2519b Gerrit-Change-Number: 40118 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-Comment-Date: Fri, 03 Apr 2020 14:26:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1695

days inactive

1695

days old

coreboot-gerrit@coreboot.org

6 comments

6 participants

tags (0)

participants (6)

9elements QA (Code Review)
Angel Pons (Code Review)
Michael Niewöhner (Code Review)
Michał Żygowski (Code Review)
Nico Huber (Code Review)
Paul Menzel (Code Review)