Attention is currently required from: Furquan Shaikh, Rizwan Qureshi, Subrata Banik, Angel Pons, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55965 )
Change subject: arch/x86: Helper functions to get deterministic cache parameters
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
I wonder if having a struct that encompasses this information would lead to a little less code, e,g.:
```
struct cpu_cache_info {
unsigned int type;
unsigned int level;
unsigned int num_ways;
unsigned int num_sets;
unsigned int line_size;
unsigned int size;
unsigned int physical_partitions;
unsigned int num_cores_shared;
bool fully_associative;
};
```
or something similar? Then there can just be a function that maybe accepts a pointer to that type and all of the helpers and caching goes away, e.g.:
```
void fill_cpu_cache_info(struct cpu_cache_info *info)
{
struct cpuid_result result;
if (!info)
return;
get_leaf();
info->type = ...
etc;
}
```
WDYT?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55965
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0dd701fb47460092448b64c7fa2162f762bf3095
Gerrit-Change-Number: 55965
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 07 Jul 2021 20:57:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment