Attention is currently required from: Tim Wawrzynczak, Michał Kopeć, Michael Niewöhner.
Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62496 )
Change subject: drivers/gfx/nvidia: Add Optimus driver based on Intel PCIe RTD3
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
File src/drivers/gfx/nvidia/optimus/optimus.c:
https://review.coreboot.org/c/coreboot/+/62496/comment/0d5b6ddb_1e62f954
PS3, Line 195: if (config->enable_gpio.pin_count) {
A GC6 compliant driver must be able to handle the JT DSM methods and decide to skip turning off power (only doing reset instead) in a few special cases, such as needing to use video memory self-refresh. This driver currently does not handle this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62496
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7bc6ec7a6a3e18417537b1f092a29972e9875282
Gerrit-Change-Number: 62496
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Fri, 04 Mar 2022 15:27:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment