HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37503 )
Change subject: superio/fintek: Fix typo ......................................................................
superio/fintek: Fix typo
Change-Id: If5c0921e20b26ce558f542f405cf62ae8d4a8101 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/fintek/common/fan_control.h M src/superio/fintek/f81803a/fan_control.c 2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/37503/1
diff --git a/src/superio/fintek/common/fan_control.h b/src/superio/fintek/common/fan_control.h index c316778..80f17dd 100644 --- a/src/superio/fintek/common/fan_control.h +++ b/src/superio/fintek/common/fan_control.h @@ -115,7 +115,7 @@ #define HWM_STATUS_INVALID_SECTION_VALUE -9 #define HWM_STATUS_BOUNDARY_WRONG_ORDER -10 #define HWM_STATUS_SECTIONS_WRONG_ORDER -11 -#define HWM_STATUS_WARNING_SENSOR_DISCONECTED 1 +#define HWM_STATUS_WARNING_SENSOR_DISCONNECTED 1 #define HWM_STATUS_WARNING_FAN_NOT_PWM 2
#define CPU_DAMAGE_TEMP 110 diff --git a/src/superio/fintek/f81803a/fan_control.c b/src/superio/fintek/f81803a/fan_control.c index 41fd0d3..a08180a 100644 --- a/src/superio/fintek/f81803a/fan_control.c +++ b/src/superio/fintek/f81803a/fan_control.c @@ -159,16 +159,16 @@ switch (sensor) { case EXTERNAL_SENSOR1: if (sensor_status & TP_EXTERNAL_SENSOR1_OPEN) { - printk(BIOS_WARNING, "Sensor 1 disconected!\n"); - return HWM_STATUS_WARNING_SENSOR_DISCONECTED; + printk(BIOS_WARNING, "Sensor 1 disconnected!\n"); + return HWM_STATUS_WARNING_SENSOR_DISCONNECTED; } hwm_reg_modify(base_address, TP_SENSOR_TYPE, TP_SENSOR1_TYPE_SHIFT, TP_SENSOR_TYPE_MASK, type); break; case EXTERNAL_SENSOR2: if (sensor_status & TP_EXTERNAL_SENSOR2_OPEN) { - printk(BIOS_WARNING, "Sensor 2 disconected!\n"); - return HWM_STATUS_WARNING_SENSOR_DISCONECTED; + printk(BIOS_WARNING, "Sensor 2 disconnected!\n"); + return HWM_STATUS_WARNING_SENSOR_DISCONNECTED; } hwm_reg_modify(base_address, TP_SENSOR_TYPE, TP_SENSOR2_TYPE_SHIFT, TP_SENSOR_TYPE_MASK, type);
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37503 )
Change subject: superio/fintek: Fix typo ......................................................................
Patch Set 1: Code-Review+1
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37503 )
Change subject: superio/fintek: Fix typo ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37503 )
Change subject: superio/fintek: Fix typo ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37503 )
Change subject: superio/fintek: Fix typo ......................................................................
superio/fintek: Fix typo
Change-Id: If5c0921e20b26ce558f542f405cf62ae8d4a8101 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/37503 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/superio/fintek/common/fan_control.h M src/superio/fintek/f81803a/fan_control.c 2 files changed, 5 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Felix Held: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/superio/fintek/common/fan_control.h b/src/superio/fintek/common/fan_control.h index c316778..80f17dd 100644 --- a/src/superio/fintek/common/fan_control.h +++ b/src/superio/fintek/common/fan_control.h @@ -115,7 +115,7 @@ #define HWM_STATUS_INVALID_SECTION_VALUE -9 #define HWM_STATUS_BOUNDARY_WRONG_ORDER -10 #define HWM_STATUS_SECTIONS_WRONG_ORDER -11 -#define HWM_STATUS_WARNING_SENSOR_DISCONECTED 1 +#define HWM_STATUS_WARNING_SENSOR_DISCONNECTED 1 #define HWM_STATUS_WARNING_FAN_NOT_PWM 2
#define CPU_DAMAGE_TEMP 110 diff --git a/src/superio/fintek/f81803a/fan_control.c b/src/superio/fintek/f81803a/fan_control.c index 41fd0d3..a08180a 100644 --- a/src/superio/fintek/f81803a/fan_control.c +++ b/src/superio/fintek/f81803a/fan_control.c @@ -159,16 +159,16 @@ switch (sensor) { case EXTERNAL_SENSOR1: if (sensor_status & TP_EXTERNAL_SENSOR1_OPEN) { - printk(BIOS_WARNING, "Sensor 1 disconected!\n"); - return HWM_STATUS_WARNING_SENSOR_DISCONECTED; + printk(BIOS_WARNING, "Sensor 1 disconnected!\n"); + return HWM_STATUS_WARNING_SENSOR_DISCONNECTED; } hwm_reg_modify(base_address, TP_SENSOR_TYPE, TP_SENSOR1_TYPE_SHIFT, TP_SENSOR_TYPE_MASK, type); break; case EXTERNAL_SENSOR2: if (sensor_status & TP_EXTERNAL_SENSOR2_OPEN) { - printk(BIOS_WARNING, "Sensor 2 disconected!\n"); - return HWM_STATUS_WARNING_SENSOR_DISCONECTED; + printk(BIOS_WARNING, "Sensor 2 disconnected!\n"); + return HWM_STATUS_WARNING_SENSOR_DISCONNECTED; } hwm_reg_modify(base_address, TP_SENSOR_TYPE, TP_SENSOR2_TYPE_SHIFT, TP_SENSOR_TYPE_MASK, type);
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
HAOUAS Elyes (Code Review)
-
Paul Menzel (Code Review)