Paul Fagerburg has submitted this change. ( https://review.coreboot.org/c/coreboot/+/72653 )
Change subject: drv/i2c/ptn3460: Use PTN_EDID_LEN instead of constant ......................................................................
drv/i2c/ptn3460: Use PTN_EDID_LEN instead of constant
Contents of the EDID are passed by a reference to an array of length 0x80, for which the macro 'PTN_EDID_LEN' has already been around.
This patch makes use of this macro within the driver and mainboard implementation utilizing it.
BUG=none TEST=A successful build of mc_apl{1,4,5,7} and mc_ehl3 mainboards.
Change-Id: If7d254aaf45d717133bb426bd08f8f9fe5c05962 Signed-off-by: Jan Samek jan.samek@siemens.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/72653 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Mario Scheithauer mario.scheithauer@siemens.com --- M src/drivers/i2c/ptn3460/ptn3460.c M src/drivers/i2c/ptn3460/ptn3460.h M src/mainboard/siemens/mc_apl1/variants/mc_apl1/lcd_panel.c M src/mainboard/siemens/mc_apl1/variants/mc_apl4/lcd_panel.c M src/mainboard/siemens/mc_apl1/variants/mc_apl5/lcd_panel.c M src/mainboard/siemens/mc_apl1/variants/mc_apl7/lcd_panel.c M src/mainboard/siemens/mc_ehl/variants/mc_ehl3/lcd_panel.c 7 files changed, 30 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Mario Scheithauer: Looks good to me, approved
diff --git a/src/drivers/i2c/ptn3460/ptn3460.c b/src/drivers/i2c/ptn3460/ptn3460.c index 31db8ad..d2df04d 100644 --- a/src/drivers/i2c/ptn3460/ptn3460.c +++ b/src/drivers/i2c/ptn3460/ptn3460.c @@ -123,7 +123,7 @@ init_done = true; }
-__weak enum cb_err mb_get_edid(uint8_t edid_data[0x80]) +__weak enum cb_err mb_get_edid(uint8_t edid_data[PTN_EDID_LEN]) { return CB_ERR; } diff --git a/src/drivers/i2c/ptn3460/ptn3460.h b/src/drivers/i2c/ptn3460/ptn3460.h index 5d867cd..ecd2191 100644 --- a/src/drivers/i2c/ptn3460/ptn3460.h +++ b/src/drivers/i2c/ptn3460/ptn3460.h @@ -52,7 +52,7 @@
/* We need functions which we can call to get mainboard specific data */ /* These functions can be implemented somewhere else but must exist. */ -extern enum cb_err mb_get_edid(uint8_t edid_data[0x80]); +extern enum cb_err mb_get_edid(uint8_t edid_data[PTN_EDID_LEN]); extern uint8_t mb_select_edid_table(void); extern enum cb_err mb_adjust_cfg(struct ptn_3460_config *cfg_ptr);
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/lcd_panel.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/lcd_panel.c index 0fce19c..8a20f36 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/lcd_panel.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/lcd_panel.c @@ -10,7 +10,7 @@ * @param edid_data pointer to EDID data in driver * @return CB_SUCCESS on successful EDID data retrieval, CB_ERR otherwise */ -enum cb_err mb_get_edid(uint8_t edid_data[0x80]) +enum cb_err mb_get_edid(uint8_t edid_data[PTN_EDID_LEN]) { const char *hwi_block = "hwinfo.hex";
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/lcd_panel.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/lcd_panel.c index d5de17d..39cc274 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/lcd_panel.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/lcd_panel.c @@ -10,7 +10,7 @@ * @param edid_data pointer to EDID data in driver * @return CB_SUCCESS on successful EDID data retrieval, CB_ERR otherwise */ -enum cb_err mb_get_edid(uint8_t edid_data[0x80]) +enum cb_err mb_get_edid(uint8_t edid_data[PTN_EDID_LEN]) { const char *hwi_block = "hwinfo.hex";
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/lcd_panel.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/lcd_panel.c index 348f762..c74e90a 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/lcd_panel.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/lcd_panel.c @@ -33,7 +33,7 @@ * @param edid_data pointer to EDID data in driver * @return CB_SUCCESS on successful EDID data retrieval, CB_ERR otherwise */ -enum cb_err mb_get_edid(uint8_t edid_data[0x80]) +enum cb_err mb_get_edid(uint8_t edid_data[PTN_EDID_LEN]) { const char *hwi_block = "hwinfo.hex";
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl7/lcd_panel.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl7/lcd_panel.c index d5de17d..39cc274 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl7/lcd_panel.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl7/lcd_panel.c @@ -10,7 +10,7 @@ * @param edid_data pointer to EDID data in driver * @return CB_SUCCESS on successful EDID data retrieval, CB_ERR otherwise */ -enum cb_err mb_get_edid(uint8_t edid_data[0x80]) +enum cb_err mb_get_edid(uint8_t edid_data[PTN_EDID_LEN]) { const char *hwi_block = "hwinfo.hex";
diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl3/lcd_panel.c b/src/mainboard/siemens/mc_ehl/variants/mc_ehl3/lcd_panel.c index 7b16254..316eb71 100644 --- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl3/lcd_panel.c +++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl3/lcd_panel.c @@ -10,7 +10,7 @@ * @param edid_data pointer to EDID data in driver * @return CB_SUCCESS on successful EDID data retrieval, CB_ERR otherwise */ -enum cb_err mb_get_edid(uint8_t edid_data[0x80]) +enum cb_err mb_get_edid(uint8_t edid_data[PTN_EDID_LEN]) { const char *hwi_block = "hwinfo.hex";